r94446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94445‎ | r94446 | r94447 >
Date:09:27, 14 August 2011
Author:hashar
Status:ok
Tags:
Comment:
MFT to REL1_18:
r92713: missing release note
r92765: simplify skin template
Password reset page fixes: r92894 r92907 r92884 r92887 r92886 r92765
(just like r92935)
r92898: remove weird unused hook
r92932: fix user_email database index
r93233: SpecialBlock double escaping bug
r93234: accessor for User->mBlock
r93149, r93151: addWiki now updates .dat & .cdb filesr93516, r93517: bug 27427 and tests
r93858: Reverted r91942,r91943,r91949,r92156 per CR
r93891: expand URLs in email notifications
r93935: Revision::newFromRow() as alias to 'new Revision()'
r94155: (bug 30074) fix up moving user JS subpages
r94346: (bug 30236) parsing of relative URLs
r94372: WikiMap now use simpler wfParseUrl()
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/CREDITS (modified) (history)
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/docs/hooks.txt (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/REL1_18/phase3/includes/CategoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_18/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/REL1_18/phase3/includes/EditPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/REL1_18/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/Revision.php (modified) (history)
  • /branches/REL1_18/phase3/includes/SkinTemplate.php (modified) (history)
  • /branches/REL1_18/phase3/includes/SpecialPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/SpecialPageFactory.php (modified) (history)
  • /branches/REL1_18/phase3/includes/Title.php (modified) (history)
  • /branches/REL1_18/phase3/includes/User.php (modified) (history)
  • /branches/REL1_18/phase3/includes/UserMailer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/Wiki.php (modified) (history)
  • /branches/REL1_18/phase3/includes/WikiCategoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/WikiMap.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiUpload.php (modified) (history)
  • /branches/REL1_18/phase3/includes/cache/MessageCache.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/Database.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseError.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseUtility.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/REL1_18/phase3/includes/interwiki/Interwiki.php (modified) (history)
  • /branches/REL1_18/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/REL1_18/phase3/includes/libs/HttpStatus.php (modified) (history)
  • /branches/REL1_18/phase3/includes/media/Exif.php (modified) (history)
  • /branches/REL1_18/phase3/includes/media/ExifBitmap.php (modified) (history)
  • /branches/REL1_18/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/REL1_18/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/REL1_18/phase3/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialBlock.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialChangePassword.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialUploadStash.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadBase.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadFromFile.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadStash.php (modified) (history)
  • /branches/REL1_18/phase3/languages (modified) (history)
  • /branches/REL1_18/phase3/languages/messages (modified) (history)
  • /branches/REL1_18/phase3/maintenance/addwiki.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/archives (modified) (history)
  • /branches/REL1_18/phase3/maintenance/archives/patch-user_email_index.sql (modified) (history)
  • /branches/REL1_18/phase3/maintenance/cleanupTable.inc (modified) (history)
  • /branches/REL1_18/phase3/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/findHooks.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/mergeMessageFileList.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/tables.sql (modified) (history)
  • /branches/REL1_18/phase3/resources/mediawiki/mediawiki.util.js (modified) (history)
  • /branches/REL1_18/phase3/tests/parser/parserTests.txt (modified) (history)
  • /branches/REL1_18/phase3/tests/parserTests.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/Makefile (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/generateRandomImages.php (modified) (history)
  • /branches/REL1_18/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.util.js (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationCommonFunction.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationConfig.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationMessage.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationVariables.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallerTestSuite.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiUserInterfaceTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/README.txt (modified) (history)
  • /branches/REL1_18/phase3/tests/testHelpers.inc (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91942Followup r91871 per CR. Write back the actually executed action to . Ping r57415diebuche09:42, 12 July 2011
r91943r91942: Add nosuchaction also if action not indiebuche09:58, 12 July 2011
r91949Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible a...diebuche11:53, 12 July 2011
r92156r91949 : EditWatchlist assumed that action was always empty for viewdiebuche13:01, 14 July 2011
r92713RELEASE-NOTES for r79383catrope23:44, 20 July 2011
r92765Address fixme on r86697: simplify the code a lot by not escaping thisquery an...catrope18:22, 21 July 2011
r92884Refactored code out into incLoginThrottle/clearLoginThrottle functions (for u...aaron20:58, 22 July 2011
r92886Follow-up r92884: mark these functions staticaaron21:04, 22 July 2011
r92887Fix for r86482: throttle password attempts for SpecialChangePassword (uses r9...aaron21:06, 22 July 2011
r92894Improved r92884 comments a bit on second thoughtaaron21:18, 22 July 2011
r92898Removed Special{$this->getName()}ModifyFormFields from r86482. Seems kind of ...aaron21:31, 22 July 2011
r92907Follow-up r92887: clear throttle count once the password is accepted as normalaaron22:42, 22 July 2011
r92932Follow-up r86482, r86485: removed user_name portion of user_email index per CRaaron08:15, 23 July 2011
r92935MFT r92907,r92894,r92887,r92886,r92884: password reset page fixes. Tweaked to...aaron09:25, 23 July 2011
r93149Made addWiki update wikiversions dat and cdb files for multiversionaaron00:27, 26 July 2011
r93151Improved r93149 error messageaaron00:33, 26 July 2011
r93233* Fix double-escaping from r85025...happy-melon19:04, 26 July 2011
r93234Implement an accessor for User->mBlock. Doing this separately as it would be...happy-melon19:27, 26 July 2011
r93516Adding unit test for bug 27427. Currently broken. Fix (provided by Michael M....krinkle07:38, 30 July 2011
r93517Adding fix for bug 27427. Fixes unit test. Patch provided by Michael M. throu...krinkle07:39, 30 July 2011
r93858Reverted r91942,r91943,r91949,r92156 per CRaaron22:08, 3 August 2011
r93891Expand all URLs in e-mail notifications to be full HTTP URLs. This prevents p...catrope15:13, 4 August 2011
r93935Adding Revision::newFromRow() function as alias for new Revision()...reedy23:25, 4 August 2011
r94155(bug 30074) Moving user JS subpages resulted in JS errors because #REDIRECT [...catrope14:23, 10 August 2011
r94346(bug 30236) Links like [[//example.com Link text]] were parsed as an internal...catrope13:32, 12 August 2011
r94372Instead of using some hacky regexes, just use wfParseUrl() in WikiMap::getDis...catrope19:19, 12 August 2011

Status & tagging log