r93935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93934‎ | r93935 | r93936 >
Date:23:25, 4 August 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Adding Revision::newFromRow() function as alias for new Revision()

More consistent with how we do stuff everywhere else
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
——@@ -122,6 +122,14 @@
123123 }
124124
125125 /**
 126+ * @param $row
 127+ * @return Revision
 128+ */
 129+ public static function newFromRow( $row ) {
 130+ return new self( $row );
 131+ }
 132+
 133+ /**
126134 * Load a page revision from a given revision ID number.
127135 * Returns null if no such revision can be found.
128136 *

Follow-up revisions

RevisionCommit summaryAuthorDate
r93936Followup r89564...reedy23:26, 4 August 2011
r93963Add @since to Revision::newFromRow per Nikerabbit...reedy12:29, 5 August 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:02, 5 August 2011

Add @since when we know which version this goes in?

Status & tagging log