r93517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93516‎ | r93517 | r93518 >
Date:07:39, 30 July 2011
Author:krinkle
Status:ok
Tags:
Comment:
Adding fix for bug 27427. Fixes unit test. Patch provided by Michael M. through BugZilla.

* (bug 27427) mw.util.getParamValue shouldn't return value from hash even if param is only present in hash.

(Follows-up r93516)
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.util.js
@@ -223,7 +223,7 @@
224224 'getParamValue' : function( param, url ) {
225225 url = url ? url : document.location.href;
226226 // Get last match, stop at hash
227 - var re = new RegExp( '[^#]*[&?]' + $.escapeRE( param ) + '=([^&#]*)' );
 227+ var re = new RegExp( '^[^#]*[&?]' + $.escapeRE( param ) + '=([^&#]*)' );
228228 var m = re.exec( url );
229229 if ( m && m.length > 1 ) {
230230 return decodeURIComponent( m[1] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r93518Release-notes for r93517krinkle07:41, 30 July 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011
r94472MFT to REL1_18:...hashar19:43, 14 August 2011
r945571.17wmf1: MFT r87099, r90729, r93141, r93517, r93891, r94155, r94277, r94372catrope20:12, 15 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93516Adding unit test for bug 27427. Currently broken. Fix (provided by Michael M....krinkle07:38, 30 July 2011

Status & tagging log