r92907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92906‎ | r92907 | r92908 >
Date:22:42, 22 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r92887: clear throttle count once the password is accepted as normal
Modified paths:
  • /trunk/phase3/includes/specials/SpecialChangePassword.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialChangePassword.php
@@ -225,6 +225,11 @@
226226 throw new PasswordError( wfMsg( 'resetpass-wrong-oldpass' ) );
227227 }
228228
 229+ // Please reset throttle for successful logins, thanks!
 230+ if ( $throttleCount ) {
 231+ LoginForm::clearLoginThrottle( $this->mUserName );
 232+ }
 233+
229234 try {
230235 $user->setPassword( $this->mNewpass );
231236 wfRunHooks( 'PrefsPasswordAudit', array( $user, $newpass, 'success' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92935MFT r92907,r92894,r92887,r92886,r92884: password reset page fixes. Tweaked to...aaron09:25, 23 July 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92887Fix for r86482: throttle password attempts for SpecialChangePassword (uses r9...aaron21:06, 22 July 2011

Status & tagging log