r92886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92885‎ | r92886 | r92887 >
Date:21:04, 22 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r92884: mark these functions static
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -587,7 +587,7 @@
588588 * @param $username string The user name
589589 * @return Bool|Integer The integer hit count or True if it is already at the limit
590590 */
591 - public function incLoginThrottle( $username ) {
 591+ public static function incLoginThrottle( $username ) {
592592 global $wgPasswordAttemptThrottle, $wgMemc;
593593
594594 $throttleCount = 0;
@@ -614,7 +614,7 @@
615615 * @param $username string The user name
616616 * @return void
617617 */
618 - public function clearLoginThrottle( $username ) {
 618+ public static function clearLoginThrottle( $username ) {
619619 global $wgMemc;
620620
621621 $throttleKey = wfMemcKey( 'password-throttle', wfGetIP(), md5( $username ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92887Fix for r86482: throttle password attempts for SpecialChangePassword (uses r9...aaron21:06, 22 July 2011
r92935MFT r92907,r92894,r92887,r92886,r92884: password reset page fixes. Tweaked to...aaron09:25, 23 July 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92884Refactored code out into incLoginThrottle/clearLoginThrottle functions (for u...aaron20:58, 22 July 2011

Status & tagging log