r92156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92155‎ | r92156 | r92157 >
Date:13:01, 14 July 2011
Author:diebuche
Status:reverted
Tags:
Comment:
r91949 : EditWatchlist assumed that action was always empty for view
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -535,7 +535,9 @@
536536 * @return int
537537 */
538538 public static function getMode( $request, $par ) {
539 - $mode = strtolower( $request->getVal( 'action', $par ) );
 539+ $act = $request->getVal( 'action' );
 540+ $mode = ( $act == 'view' ) ? $par : $act;
 541+ $mode = strtolower( $mode );
540542 switch( $mode ) {
541543 case 'clear':
542544 case self::EDIT_CLEAR:

Follow-up revisions

RevisionCommit summaryAuthorDate
r93858Reverted r91942,r91943,r91949,r92156 per CRaaron22:08, 3 August 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91949Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible a...diebuche11:53, 12 July 2011

Status & tagging log