r92894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92893‎ | r92894 | r92895 >
Date:21:18, 22 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Improved r92884 comments a bit on second thought
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -582,8 +582,8 @@
583583 }
584584
585585 /*
586 - * Increment the login attempt throttle hit count for a user
587 - * and then check if the (username,IP) combination is throttled.
 586+ * Increment the login attempt throttle hit count for the (username,current IP)
 587+ * tuple unless the throttle was already reached.
588588 * @param $username string The user name
589589 * @return Bool|Integer The integer hit count or True if it is already at the limit
590590 */
@@ -610,7 +610,7 @@
611611 }
612612
613613 /*
614 - * Clear the login attempt throttle hit count for a user
 614+ * Clear the login attempt throttle hit count for the (username,current IP) tuple.
615615 * @param $username string The user name
616616 * @return void
617617 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r92935MFT r92907,r92894,r92887,r92886,r92884: password reset page fixes. Tweaked to...aaron09:25, 23 July 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92884Refactored code out into incLoginThrottle/clearLoginThrottle functions (for u...aaron20:58, 22 July 2011

Status & tagging log