r92932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92931‎ | r92932 | r92933 >
Date:08:15, 23 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r86482, r86485: removed user_name portion of user_email index per CR
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-user_email_index.sql (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-user_email_index.sql
@@ -1 +1 @@
2 -CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50),user_name);
\ No newline at end of file
 2+CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50));
Index: trunk/phase3/maintenance/tables.sql
@@ -135,7 +135,7 @@
136136
137137 CREATE UNIQUE INDEX /*i*/user_name ON /*_*/user (user_name);
138138 CREATE INDEX /*i*/user_email_token ON /*_*/user (user_email_token);
139 -CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50),user_name);
 139+CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50));
140140
141141
142142 --
@@ -164,7 +164,7 @@
165165 CREATE UNIQUE INDEX /*i*/ug_user_group ON /*_*/user_groups (ug_user,ug_group);
166166 CREATE INDEX /*i*/ug_group ON /*_*/user_groups (ug_group);
167167
 168+-- Stores the groups the user has once belonged to.
168169 -- The user may still belong these groups. Check user_groups.
169170 CREATE TABLE /*_*/user_former_groups (
170171 -- Key to user_id
@@ -939,12 +939,12 @@
940940
941941
942942 --
 943+-- Store information about newly uploaded files before they're
943944 -- moved into the actual filestore
944945 --
945946 CREATE TABLE /*_*/uploadstash (
946947 us_id int unsigned NOT NULL PRIMARY KEY auto_increment,
947 -
 948+
948949 -- the user who uploaded the file.
949950 us_user int unsigned NOT NULL,
950951
@@ -954,16 +954,16 @@
955955
956956 -- the original path
957957 us_orig_path varchar(255) NOT NULL,
958 -
 958+
959959 -- the temporary path at which the file is actually stored
960960 us_path varchar(255) NOT NULL,
961 -
 961+
962962 -- which type of upload the file came from (sometimes)
963963 us_source_type varchar(50),
964 -
 964+
965965 -- the date/time on which the file was added
966966 us_timestamp varbinary(14) not null,
967 -
 967+
968968 us_status varchar(50) not null,
969969
970970 -- file properties from File::getPropsFromPath. these may prove unnecessary.
@@ -978,7 +978,7 @@
979979 us_image_width int unsigned,
980980 us_image_height int unsigned,
981981 us_image_bits smallint unsigned
982 -
 982+
983983 ) /*$wgDBTableOptions*/;
984984
985985 -- sometimes there's a delete for all of a user's stuff.

Follow-up revisions

RevisionCommit summaryAuthorDate
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86482(bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate t...happy-melon15:27, 20 April 2011
r86485Follow-up r86482: patch to add an index on user_email. Not a problem if this...happy-melon15:33, 20 April 2011
r86527Follow-up r86485: SQL error in patch, and also add the index to tables.sql.happy-melon19:02, 20 April 2011

Status & tagging log