r83559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83558‎ | r83559 | r83560 >
Date:00:27, 9 March 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.17wmf1: MFT r83544, r83545. Were already deployed on WMF
Modified paths:
  • /branches/wmf/1.17wmf1/includes/CategoryPage.php (modified) (history)
  • /branches/wmf/1.17wmf1/maintenance/updateCollation.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/maintenance/updateCollation.php
@@ -10,7 +10,7 @@
1111 require_once( dirname( __FILE__ ) . '/Maintenance.php' );
1212
1313 class UpdateCollation extends Maintenance {
14 - const BATCH_SIZE = 1000;
 14+ const BATCH_SIZE = 50;
1515
1616 public function __construct() {
1717 parent::__construct();
Property changes on: branches/wmf/1.17wmf1/maintenance/updateCollation.php
___________________________________________________________________
Added: svn:mergeinfo
1818 Merged /branches/wmf/1.16wmf4/maintenance/updateCollation.php:r67177,69199,76243,77266
1919 Merged /branches/sqlite/maintenance/updateCollation.php:r58211-58321
2020 Merged /trunk/phase3/maintenance/updateCollation.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81833,83212,83545
2121 Merged /branches/new-installer/phase3/maintenance/updateCollation.php:r43664-66004
2222 Merged /branches/wmf-deployment/maintenance/updateCollation.php:r60970
2323 Merged /branches/REL1_15/phase3/maintenance/updateCollation.php:r51646
Index: branches/wmf/1.17wmf1/includes/CategoryPage.php
@@ -312,7 +312,7 @@
313313 $count = 0;
314314 foreach ( $res as $row ) {
315315 $title = Title::newFromRow( $row );
316 - $rawSortkey = $title->getCategorySortkey( $row->cl_sortkey_prefix );
 316+ $rawSortkey = $row->cl_sortkey;
317317
318318 if ( ++$count > $this->limit ) {
319319 # We've reached the one extra which shows that there
Property changes on: branches/wmf/1.17wmf1/includes/CategoryPage.php
___________________________________________________________________
Added: svn:mergeinfo
320320 Merged /branches/new-installer/phase3/includes/CategoryPage.php:r43664-66004
321321 Merged /branches/wmf-deployment/includes/CategoryPage.php:r53381,60970
322322 Merged /branches/REL1_15/phase3/includes/CategoryPage.php:r51646
323323 Merged /branches/wmf/1.16wmf4/includes/CategoryPage.php:r67177,69199,76243,77266
324324 Merged /branches/sqlite/includes/CategoryPage.php:r58211-58321
325325 Merged /trunk/phase3/includes/CategoryPage.php:r83544

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83544Don't regenerate raw sortkeys in CategoryPage.php...simetrical20:49, 8 March 2011
r83545Change collationUpdate batch size from 1000 to 50...simetrical21:21, 8 March 2011

Comments

#Comment by 😂 (talk | contribs)   15:24, 19 April 2011

The change from r83544 was reverted in r86100, it's already tagged for merge.

Status & tagging log