r82474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82473‎ | r82474 | r82475 >
Date:19:21, 19 February 2011
Author:catrope
Status:ok
Tags:
Comment:
Revert r74387: it may not fix the IE8 jumping bug in all cases, but it definitely fixes it in most cases. Reverting a partial fix for not being perfect, then never coming up with a full fix is not acceptable.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/skins/common/IE80Fixes.css (added) (history)

Diff [purge]

Index: trunk/phase3/skins/common/IE80Fixes.css
@@ -0,0 +1,15 @@
 2+/**
 3+ * Fixes textarea scrolling bug (bug #19334). The bug only occurs when a
 4+ * percentage width is given, so instead of width: 100%, use min-width: 100%;
 5+ * max-width: 100%. We also need to give a fixed width for the actual width
 6+ * property for the hack to work, although the actual value (500px here) ends
 7+ * up being ignored; min/max-width take precedence.
 8+ *
 9+ * More info: http://grantovich.net/posts/2009/06/that-weird-ie8-textarea-bug/
 10+ */
 11+#wpTextbox1 {
 12+ height: 390px;
 13+ width: 500px;
 14+ min-width: 100%;
 15+ max-width: 100%;
 16+}
Property changes on: trunk/phase3/skins/common/IE80Fixes.css
___________________________________________________________________
Added: svn:eol-style
117 + native
Index: trunk/phase3/includes/EditPage.php
@@ -371,6 +371,8 @@
372372 if ( $wgUser->getOption( 'uselivepreview', false ) ) {
373373 $wgOut->addModules( 'mediawiki.legacy.preview' );
374374 }
 375+ // Bug #19334: textarea jumps when editing articles in IE8
 376+ $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 8' );
375377
376378 $permErrors = $this->getEditPermissionErrors();
377379 if ( $permErrors ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011
r85342MFT r82465, r82468, r82474 (second try), followup to r85211demon17:05, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74387Removed CSS file/rule which was added to fix a bug it never actually fixed. M...tparscal20:37, 6 October 2010

Status & tagging log