r82404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82403‎ | r82404 | r82405 >
Date:15:33, 18 February 2011
Author:thomasv
Status:ok (Comments)
Tags:
Comment:
fix bug 27454: confusion between / and /
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -856,11 +856,9 @@
857857 if( !$is_q0 ) {
858858 $out .= '<span>{{:MediaWiki:Proofreadpage_pagenum_template|page=' . $text . "|num=$pagenum}}</span>";
859859 }
860 - if( $args["$i"] != null ) {
861 - $out .= '{{#lst:' . $text . '|' . $args["$i"] . '}}';
862 - } elseif( $page == $from && $args['fromsection'] ) {
 860+ if( $page == $from_page && $args['fromsection'] ) {
863861 $out .= '{{#lst:' . $text . '|' . $args['fromsection'] . '}}';
864 - } elseif( $page == $to && $args['tosection'] ) {
 862+ } elseif( $page == $to_page && $args['tosection'] ) {
865863 $out .= '{{#lst:' . $text . '|' . $args['tosection'] . '}}';
866864 } else {
867865 $out .= '{{:' . $text . '}}';

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Comments

#Comment by ThomasV (talk | contribs)   15:35, 18 February 2011

the comment shoud read : confusion between $from/$to and $from_page/$to_page

#Comment by 😂 (talk | contribs)   15:46, 18 February 2011

Somebody committed with -m :)

Status & tagging log