r74387 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74386‎ | r74387 | r74388 >
Date:20:37, 6 October 2010
Author:tparscal
Status:reverted (Comments)
Tags:
Comment:
Removed CSS file/rule which was added to fix a bug it never actually fixed. More investigation needs to be put into bug #19334
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/skins/common/IE80Fixes.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/common/IE80Fixes.css
@@ -1,15 +0,0 @@
2 -/**
3 - * Fixes textarea scrolling bug (bug #19334). The bug only occurs when a
4 - * percentage width is given, so instead of width: 100%, use min-width: 100%;
5 - * max-width: 100%. We also need to give a fixed width for the actual width
6 - * property for the hack to work, although the actual value (500px here) ends
7 - * up being ignored; min/max-width take precedence.
8 - *
9 - * More info: http://grantovich.net/posts/2009/06/that-weird-ie8-textarea-bug/
10 - */
11 -#wpTextbox1 {
12 - height: 390px;
13 - width: 500px;
14 - min-width: 100%;
15 - max-width: 100%;
16 -}
Index: trunk/phase3/includes/EditPage.php
@@ -324,8 +324,6 @@
325325 $wgOut->includeJQuery();
326326 $wgOut->addModules( 'mediawiki.legacy.preview' );
327327 }
328 - // Bug #19334: textarea jumps when editing articles in IE8
329 - $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 8' );
330328
331329 $permErrors = $this->getEditPermissionErrors();
332330 if ( $permErrors ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r82474Revert r74387: it may not fix the IE8 jumping bug in all cases, but it defini...catrope19:21, 19 February 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   20:42, 6 October 2010

resources/Resources.php is updated in r74388.

Status & tagging log