r78897 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78896‎ | r78897 | r78898 >
Date:17:50, 23 December 2010
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
didn't mean to commit this
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
——@@ -78,10 +78,6 @@
7979 'jquery.localize' => array(
8080 'scripts' => 'resources/jquery/jquery.localize.js'
8181 ),
82 - 'jquery.makeCollapsible' => array(
83 - 'scripts' => 'resources/jquery/jquery.makeCollapsible.js',
84 - 'styles' => 'resources/jquery/jquery.makeCollapsible.css',
85 - ),
8682 'jquery.suggestions' => array(
8783 'scripts' => 'resources/jquery/jquery.suggestions.js',
8884 'styles' => 'resources/jquery/jquery.suggestions.css',

Follow-up revisions

RevisionCommit summaryAuthorDate
r78909Fix r78897: remove dependency on makeCollapsible as wellcatrope18:38, 23 December 2010
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011
r85343Fix for r85080: re-merge r78344, r78893, r78897, r78909demon17:13, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78893using .append() instead of innerHTML+=. The latter replaces the html and caus...krinkle16:36, 23 December 2010

Comments

#Comment by Krinkle (talk | contribs)   22:09, 19 February 2011

Because r78893 (up for merging to 1.17wmf1) committed this by accident this one should be merged as well to prevent problems.

Tagging 1.17wmf1

Status & tagging log