r82312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82311‎ | r82312 | r82313 >
Date:23:38, 16 February 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 27479) API error when using both prop=pageprops and prop=info&inprop=displaytitle

Followup r75282

Patch by Brad Jorsch
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryPageProps.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryPageProps.php
@@ -112,7 +112,7 @@
113113 * @return bool True if it fits in the result
114114 */
115115 private function addPageProps( $result, $page, $props ) {
116 - $fit = $result->addValue( array( 'query', 'pages' ), $page, $props );
 116+ $fit = $result->addValue( array( 'query', 'pages', $page ), 'pageprops', $props );
117117
118118 if ( !$fit ) {
119119 $this->setContinueEnumParameter( 'continue', $page );
Index: trunk/phase3/RELEASE-NOTES
@@ -173,6 +173,8 @@
174174 * (bug 27199) Thumbnail urls can be fetched for old files as well
175175 * (bug 27376) when using ApiBase::PARAM_TYPE => 'integer' without a min or
176176 max value, api doesn't validate the input is actually an integer
 177+* (bug 27479) API error when using both prop=pageprops and
 178+ prop=info&inprop=displaytitle
177179
178180 === Languages updated in 1.18 ===
179181

Follow-up revisions

RevisionCommit summaryAuthorDate
r823631.17wmf1: MFT r82297, r82312, r82337catrope23:16, 17 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75282Follow-up r70638:...btongminh18:53, 23 October 2010

Status & tagging log