r82297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82296‎ | r82297 | r82298 >
Date:21:30, 16 February 2011
Author:platonides
Status:ok
Tags:
Comment:
Fix the issue where all links on Special:Contributions where marked as stubs (NS_MAIN pages, for users with a stub threshold) broken since r63584.
resetArticleId() is clearing the right data set by Title::newFromRow() and placing just the id, which in turn avoids to lookup the other items.
This was already done in 1.16 (since r46179, it was useful until r46181) but resetArticleID() did not reset everything (r63584 change) and so
the bug wasn't present there.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
——@@ -637,7 +637,6 @@
638638 $classes = array();
639639
640640 $page = Title::newFromRow( $row );
641 - $page->resetArticleId( $row->rev_page ); // use process cache
642641 $link = $sk->link(
643642 $page,
644643 htmlspecialchars( $page->getPrefixedText() ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r823631.17wmf1: MFT r82297, r82312, r82337catrope23:16, 17 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46179Improve article ID process cache hit rateaaron01:37, 25 January 2009
r46181Revert r46180 and use newFromRow to get page_is_redirect loaded correctlyaaron02:02, 25 January 2009
r63584Made resetArticleID() reset redirect/length/latest ID fieldsaaron05:32, 11 March 2010

Status & tagging log