r82465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82464‎ | r82465 | r82466 >
Date:16:48, 19 February 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix logic error in r73204 (!) causing ResourceLoaderContext::getHash() to always return null
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderContext.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderContext.php
@@ -131,7 +131,7 @@
132132 }
133133
134134 public function getHash() {
135 - if ( isset( $this->hash ) ) {
 135+ if ( !isset( $this->hash ) ) {
136136 $this->hash = implode( '|', array(
137137 $this->getLanguage(), $this->getDirection(), $this->skin, $this->user,
138138 $this->debug, $this->only, $this->version

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011
r85342MFT r82465, r82468, r82474 (second try), followup to r85211demon17:05, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73204Minor resource loader changes:...tstarling11:45, 17 September 2010

Status & tagging log