r80495 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80494‎ | r80495 | r80496 >
Date:15:33, 18 January 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
This override is no longer needed.
Tables in <div class="toccolours"> or in other places no longer force a white background which was only added to avoid underlines from <h2> headings from shining through (which is no longer the case since bug 26449 was solved in r79087 and r79091)
* This commit fixes bug 26708
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
——@@ -63,12 +63,9 @@
6464 table {
6565 font-size: 100%;
6666 color: black;
67 - /* we don't want the bottom borders of <h2>s to be visible through
68 - floated tables */
69 - background-color: white;
7067 }
7168 fieldset table {
72 - /* but keep table layouts in forms clean... */
 69+ /* keep table layouts in forms clean from background colors... */
7370 background: none;
7471 }
7572 a {
Index: trunk/phase3/skins/vector/screen.css
——@@ -811,12 +811,9 @@
812812 table {
813813 font-size: 100%;
814814 color: black;
815 - /* we don't want the bottom borders of <h2>s to be visible through
816 - * floated tables */
817 - background-color: white;
818815 }
819816 fieldset table {
820 - /* but keep table layouts in forms clean... */
 817+ /* keep table layouts in forms clean from background colors... */
821818 background: none;
822819 }
823820 /* Forms */
Index: trunk/phase3/RELEASE-NOTES
——@@ -95,6 +95,9 @@
9696 cell is now treated as a linestart.
9797 * Custom editintro's using the editintro url parameter will no longer show <noinclude>
9898 sections on pages they are included on.
 99+* (bug 26449) Keep underlines from headings outside of tables and thumbs by
 100+ adding overflow:hidden to h1,h2,h3,h4,h5,h6 (also fixes editsection bunching).
 101+* (bug 26708) Remove background-color:white from tables in Monobook and Vector.
99102
100103 === API changes in 1.18 ===
101104 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r80765This override is no longer needed. white background for tables removed in r80...krinkle20:30, 22 January 2011
r81177Removing more, no longer needed, overrides for the white table background (w...krinkle23:30, 28 January 2011
r822201.17wmf1: MFT r80495, r80765, r81177, r82000, r82155, r82156, r82191, r82200,...catrope07:23, 16 February 2011
r85148MFT: r80495, r80610, r80765, r81177, r81490, r81692, r81707, r81729, r81765, ...demon20:11, 1 April 2011
r108975[mediawiki.action.history.diff.css] remove redundant css rule...krinkle13:56, 15 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79087Adding overflow:hidden to heading elements in Vector....krinkle20:53, 27 December 2010
r79091* Follow-up r79087. Applying to other skins that have similar article styling...krinkle23:23, 27 December 2010

Comments

#Comment by Fomafix (talk | contribs)   16:03, 18 January 2011

fieldset table { background: none; } was added in r32270 and can be removed because table hase no white background color anymore.

#Comment by Krinkle (talk | contribs)   17:56, 18 January 2011

@Fomafix: I kept it in this commit, and was/am going to do a full check to be sure it's not getting a background color in the core from anything else.

Thanks for the reinsurance, I'll remove it for sure.

#Comment by Krinkle (talk | contribs)   20:30, 22 January 2011

Done in r80765.

#Comment by Fomafix (talk | contribs)   10:56, 23 January 2011

In phase3/skins/common/shared.css 

table#mw-search-top-table { background-color: transparent; }

from r52669/r55748 is also not neccessary anymore.

#Comment by Fomafix (talk | contribs)   08:09, 24 January 2011

In phase3/skins/common/shared.css 

table.allpageslist,
table.mw-allpages-table-form,
table.mw-allpages-table-chunk {
  background-color: transparent;
}

from r49500 are also not necessary anymore.

#Comment by Fomafix (talk | contribs)   08:27, 24 January 2011

In phase3/skins/common/shared.css 

table#mw-prefixindex-list-table,
table#mw-prefixindex-nav-table {
  background-color: transparent;
}

from r47299 are also not necessary anymore.

#Comment by Fomafix (talk | contribs)   11:27, 26 January 2011

In phase3/resources/mediawiki.special/mediawiki.special.changeslist.css 

table.mw-enhanced-rc { background: none; }

from r32269, r55393, r78865 is not necessary anymore.

#Comment by Krinkle (talk | contribs)   15:32, 26 January 2011

Thanks a lot for this list!

#Comment by Fomafix (talk | contribs)   14:30, 12 January 2012

In svn:trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css 

table.diff,
td.diff-otitle,
td.diff-ntitle {
	background-color: transparent;
}

from r105280 is not necessary anymore.

#Comment by Krinkle (talk | contribs)   13:57, 15 January 2012

Done in r108975.

Status & tagging log