r52669 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52668‎ | r52669 | r52670 >
Date:00:25, 2 July 2009
Author:rainman
Status:resolved (Comments)
Tags:
Comment:
Fix background color of the searchbox and "did you mean" link table... since this had no style it used the white background of content tables
which is bad since some wikis have custom background colors for special pages.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -288,7 +288,11 @@
289289 font-weight: bold;
290290 }
291291
 292+table#mw-search-top-table {
 293+ background-color:inherit;
 294+}
292295
 296+
293297 /*
294298 * Advanced PowerSearch box
295299 */
Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -203,7 +203,7 @@
204204 )
205205 );
206206 $wgOut->addHtml(
207 - Xml::openElement( 'table', array( 'border'=>0, 'cellpadding'=>0, 'cellspacing'=>0 ) ) .
 207+ Xml::openElement( 'table', array( 'id'=>'mw-search-top-table', 'border'=>0, 'cellpadding'=>0, 'cellspacing'=>0 ) ) .
208208 Xml::openElement( 'tr' ) .
209209 Xml::openElement( 'td' ) . "\n" .
210210 $this->shortDialog( $term ) .

Follow-up revisions

RevisionCommit summaryAuthorDate
r55748Use transparent instead of inherit, for compatibility with IE, as suggested b...tstarling07:47, 2 September 2009
r81177Removing more, no longer needed, overrides for the white table background (w...krinkle23:30, 28 January 2011

Comments

#Comment by Simetrical (talk | contribs)   02:49, 3 July 2009

"inherit" doesn't work in IE6 or IE7. "transparent" should do the trick.

Or, people could use non-broken CSS rules so this is unnecessary. People who change the background color of the contents should change the background color of tables as well. Anything else is broken and stupid AFAICT. But this has been said before and nobody ever fixed it, so maybe they have some reason I don't know of . . .

Status & tagging log