r32269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32268‎ | r32269 | r32270 >
Date:22:51, 20 March 2008
Author:brion
Status:old
Tags:
Comment:
hackaround for table background hardcoded in monobook
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -505,7 +505,7 @@
506506 */
507507 function recentChangesBlockGroup( $block ) {
508508 global $wgLang, $wgContLang, $wgRCShowChangedSize;
509 - $r = '<table cellpadding="0" cellspacing="0" border="0"><tr>';
 509+ $r = '<table cellpadding="0" cellspacing="0" border="0" style="background: none"><tr>';
510510
511511 # Collate list of users
512512 $isnew = false;
@@ -617,7 +617,7 @@
618618 $r .= "</td></tr></table>\n";
619619
620620 # Sub-entries
621 - $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0" border="0">';
 621+ $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0" border="0" style="background: none">';
622622 foreach( $block as $rcObj ) {
623623 # Get rc_xxxx variables
624624 // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
@@ -756,7 +756,7 @@
757757 extract( $rcObj->mAttribs );
758758 $curIdEq = 'curid='.$rc_cur_id;
759759
760 - $r = '<table cellspacing="0" cellpadding="0" border="0"><tr>';
 760+ $r = '<table cellspacing="0" cellpadding="0" border="0" style="background: none"><tr>';
761761
762762 $r .= '<td valign="top" style="white-space: nowrap"><tt>' . $this->spacerArrow() . '&nbsp;';
763763

Follow-up revisions

RevisionCommit summaryAuthorDate
r81177Removing more, no longer needed, overrides for the white table background (w...krinkle23:30, 28 January 2011

Status & tagging log