r80610 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r80609‎ \| r80610 \| r80611 >
Date:	01:49, 20 January 2011
Author:	bawolff
Status:	ok (Comments)
Tags:
Comment:	(bug 26716, well partially anyways. kind of second half of r80608) Add a comment to external editor ini control file explaining what it is. This will give people who accidently select the preference a fighting chance to debug what is going on. Of course, since it has a mime type of application/x-external-edit (or something like that), and the download would have a .php extension, the chance they will open it in a text editor is pretty slim... See bug 2760 for proposal to just kill the preference altogether.
Modified paths:	/trunk/phase3/RELEASE-NOTES (modified) (history) /trunk/phase3/includes/ExternalEdit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalEdit.php
—	—	@@ -53,6 +53,11 @@
54	54	}
55	55	$special=$wgLang->getNsText(NS_SPECIAL);
56	56	$control = <<<CONTROL
	57	+; You're seeing this file because you're using Mediawiki's External Editor
	58	+; feature. This is probably because you selected use external editor
	59	+; in your preferences. To edit normally, either disable that preference
	60	+; or go to the URL $url .
	61	+; See http://www.mediawiki.org/wiki/Manual:External_editors for details.
57	62	[Process]
58	63	Type=$type
59	64	Engine=MediaWiki
Index: trunk/phase3/RELEASE-NOTES
—	—	@@ -99,7 +99,8 @@
100	100	adding overflow:hidden to h1,h2,h3,h4,h5,h6 (also fixes editsection bunching).
101	101	* (bug 26708) Remove background-color:white from tables in Monobook and Vector.
102	102	* (bug 26781) {{PAGENAME}} and related parser functions escape their output better.
103		~~-* (bug 26716) Provide link to instructions for external editor related preferences.~~
	103	+* (bug 26716) Provide link to instructions for external editor related preferences
	104	+ and add a comment to the ini control file explaining what is going on.
104	105
105	106	=== API changes in 1.18 ===
106	107	* (bug 26339) Throw warning when truncating an overlarge API result

Revision	Commit summary	Author	Date
r85148	MFT: r80495, r80610, r80765, r81177, r81490, r81692, r81707, r81729, r81765, ...	demon	20:11, 1 April 2011

Revision	Commit summary	Author	Date
r80608	(bug 26716) Provide a link for setup instructions for external editor related...	bawolff	01:04, 20 January 2011

#Comment by Hashar (talk | contribs) 10:56, 13 February 2011

tagging 1.17 since previous r80608 got merged in 1.17

20:13, 1 April 2011 😂 (talk | contribs) changed the tags for r80610 [removed: 1.17]
10:56, 13 February 2011 Hashar (talk | contribs) changed the tags for r80610 [added: 1.17]
10:56, 13 February 2011 Hashar (talk | contribs) changed the status of r80610 [removed: new added: ok]