r79091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79090‎ | r79091 | r79092 >
Date:23:23, 27 December 2010
Author:krinkle
Status:ok
Tags:
Comment:
* Follow-up r79087. Applying to other skins that have similar article styling in relation to headings and thumbs.
* Follow-up r79086. Fixing margin (I shouldn't have added the numbers, caused the margins to be a litle bigger then they were, now they're the same as before the border>margin change)
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -47,6 +47,7 @@
4848 background: none;
4949 font-weight: normal;
5050 margin: 0;
 51+ overflow: hidden;
5152 padding-top: 0.5em;
5253 padding-bottom: 0.17em;
5354 border-bottom: 1px solid #aaaaaa;
@@ -316,7 +317,7 @@
317318 div.tleft {
318319 float: left;
319320 clear: left;
320 - margin: 0.5em 1.9em 1.3em 0;
 321+ margin: 0.5em 1.4em 1.3em 0;
321322 }
322323 img.thumbborder {
323324 border: 1px solid #dddddd;
Index: trunk/phase3/skins/monobook/main.css
@@ -120,6 +120,7 @@
121121 background: none;
122122 font-weight: normal;
123123 margin: 0;
 124+ overflow: hidden;
124125 padding-top: .5em;
125126 padding-bottom: .17em;
126127 border-bottom: 1px solid #aaa;
@@ -450,7 +451,7 @@
451452 div.tleft {
452453 float: left;
453454 clear: left;
454 - margin: .5em 1.9em 1.3em 0;
 455+ margin: .5em 1.4em 1.3em 0;
455456 }
456457 img.thumbborder {
457458 border: 1px solid #dddddd;
Index: trunk/phase3/skins/modern/main.css
@@ -333,6 +333,10 @@
334334 border-bottom: solid 1px #003366;
335335 }
336336
 337+h1, h2, h3, h4, h5, h6 {
 338+ overflow: hidden;
 339+}
 340+
337341 #preftoc {
338342 width: 100%;
339343 margin: 0 0 0 0;
@@ -525,7 +529,7 @@
526530 div.tleft {
527531 float: left;
528532 clear: left;
529 - margin: .5em 1.9em .8em 0;
 533+ margin: .5em 1.4em .8em 0;
530534 }
531535 img.thumbborder {
532536 border: 1px solid #dddddd;
Index: trunk/phase3/skins/vector/screen.css
@@ -934,7 +934,7 @@
935935 div.tleft {
936936 float: left;
937937 clear: left;
938 - margin: .5em 1.9em 1.3em 0;
 938+ margin: .5em 1.4em 1.3em 0;
939939 }
940940 img.thumbborder {
941941 border: 1px solid #dddddd;

Follow-up revisions

RevisionCommit summaryAuthorDate
r80495This override is no longer needed. ...krinkle15:33, 18 January 2011
r81177Removing more, no longer needed, overrides for the white table background (w...krinkle23:30, 28 January 2011
r821511.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,...catrope22:55, 14 February 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79086Room around thumbs should be margin, not a transparent border....krinkle20:45, 27 December 2010
r79087Adding overflow:hidden to heading elements in Vector....krinkle20:53, 27 December 2010

Status & tagging log