r79087 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79086‎ | r79087 | r79088 >
Date:20:53, 27 December 2010
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Adding overflow:hidden to heading elements in Vector.

This has been tested in Vector in a large number of browsers to not have side effects and only making the underline no longer shine through transparent borders or margins of thumbs.
Also, due to float clearing abilities of overflow:hidden (it's all over the internet) this also causes the editsection link to no longer be stacked down (see en.wiki WP:BUNCH), see bug 26449.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
——@@ -699,6 +699,7 @@
700700 background: none;
701701 font-weight: normal;
702702 margin: 0;
 703+ overflow: hidden;
703704 padding-top: .5em;
704705 padding-bottom: .17em;
705706 border-bottom: 1px solid #aaa;

Follow-up revisions

RevisionCommit summaryAuthorDate
r79091* Follow-up r79087. Applying to other skins that have similar article styling...krinkle23:23, 27 December 2010
r80495This override is no longer needed. ...krinkle15:33, 18 January 2011
r81177Removing more, no longer needed, overrides for the white table background (w...krinkle23:30, 28 January 2011
r821511.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,...catrope22:55, 14 February 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011

Comments

#Comment by Simetrical (talk | contribs)   00:06, 30 January 2011

Sounds good to me. IIRC, we tried this a few years ago but backed it out because it caused major problems in IE5/Mac (like all the headings disappearing or something). So it should be totally fine now.

Status & tagging log