r82200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82199‎ | r82200 | r82201 >
Date:22:14, 15 February 2011
Author:tparscal
Status:ok
Tags:
Comment:
Grouped diff and history modules together to help reduce cache invalidation. Loaded diff styles statically. This should help with bug #27418, but I suspect there are more cases where we need to do this sort of thing before the bug is truly resolved.
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -584,7 +584,8 @@
585585 */
586586 function showDiffStyle() {
587587 global $wgOut;
588 - $wgOut->addModules( 'mediawiki.legacy.diff' );
 588+ $wgOut->addModuleStyles( 'mediawiki.legacy.diff' );
 589+ $wgOut->addModuleScripts( 'mediawiki.legacy.diff' );
589590 }
590591
591592 /**
Index: trunk/phase3/resources/Resources.php
@@ -399,6 +399,7 @@
400400 'mediawiki.action.history' => array(
401401 'scripts' => 'resources/mediawiki.action/mediawiki.action.history.js',
402402 'dependencies' => 'mediawiki.legacy.history',
 403+ 'group' => 'mediawiki.action.history',
403404 ),
404405 'mediawiki.action.edit' => array(
405406 'scripts' => 'resources/mediawiki.action/mediawiki.action.edit.js',
@@ -522,6 +523,7 @@
523524 'mediawiki.legacy.diff' => array(
524525 'scripts' => 'common/diff.js',
525526 'styles' => 'common/diff.css',
 527+ 'group' => 'mediawiki.action.history',
526528 'remoteBasePath' => $GLOBALS['wgStylePath'],
527529 'localBasePath' => "{$GLOBALS['IP']}/skins",
528530 'dependencies' => 'mediawiki.legacy.wikibits',
@@ -534,6 +536,7 @@
535537 ),
536538 'mediawiki.legacy.history' => array(
537539 'scripts' => 'common/history.js',
 540+ 'group' => 'mediawiki.action.history',
538541 'remoteBasePath' => $GLOBALS['wgStylePath'],
539542 'localBasePath' => "{$GLOBALS['IP']}/skins",
540543 'dependencies' => 'mediawiki.legacy.wikibits',

Follow-up revisions

RevisionCommit summaryAuthorDate
r822201.17wmf1: MFT r80495, r80765, r81177, r82000, r82155, r82156, r82191, r82200,...catrope07:23, 16 February 2011
r85151MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ...demon20:39, 1 April 2011
r85348Fixes for r85151: grab Resources.php changes for r81719, r81721, r81722, r822...demon17:41, 4 April 2011

Status & tagging log