r79086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79085‎ | r79086 | r79087 >
Date:20:45, 27 December 2010
Author:krinkle
Status:ok
Tags:
Comment:
Room around thumbs should be margin, not a transparent border.

.tleft / .tright { border-width: 0.5em 0 0.8em 1.4em; }
becomes: "margin: 0.5em 0 0.8em 1.4em;"
adding ".thumb margin-bottom: 0.5em;" becomes: "margin: 0.5em 0 1.3em 1.4em;"
* Related to r79010
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -279,8 +279,6 @@
280280 /* thumbnails */
281281 div.thumb {
282282 margin-bottom: 0.5em;
283 - border-style: solid;
284 - border-color: transparent;
285283 width: auto;
286284 }
287285 div.thumbinner {
@@ -313,13 +311,12 @@
314312 div.tright {
315313 clear: right;
316314 float: right;
317 - border-width: 0.5em 0 0.8em 1.4em;
 315+ margin: 0.5em 0 1.3em 1.4em;
318316 }
319317 div.tleft {
320318 float: left;
321319 clear: left;
322 - margin-right:0.5em;
323 - border-width: 0.5em 1.4em 0.8em 0;
 320+ margin: 0.5em 1.9em 1.3em 0;
324321 }
325322 img.thumbborder {
326323 border: 1px solid #dddddd;
Index: trunk/phase3/skins/monobook/main.css
@@ -410,8 +410,6 @@
411411 /* thumbnails */
412412 div.thumb {
413413 margin-bottom: .5em;
414 - border-style: solid;
415 - border-color: transparent;
416414 width: auto;
417415 }
418416 div.thumbinner {
@@ -446,14 +444,13 @@
447445 div.tright {
448446 clear: right;
449447 float: right;
450 - border-width: .5em 0 .8em 1.4em;
 448+ margin: .5em 0 1.3em 1.4em;
451449 }
452450 /* @noflip */
453451 div.tleft {
454452 float: left;
455453 clear: left;
456 - margin-right: .5em;
457 - border-width: .5em 1.4em .8em 0;
 454+ margin: .5em 1.9em 1.3em 0;
458455 }
459456 img.thumbborder {
460457 border: 1px solid #dddddd;
Index: trunk/phase3/skins/modern/main.css
@@ -487,8 +487,6 @@
488488 /* thumbnails */
489489 div.thumb {
490490 margin-bottom: .5em;
491 - border-style: solid;
492 - border-color: transparent;
493491 width: auto;
494492 }
495493 div.thumbinner {
@@ -522,13 +520,12 @@
523521 div.tright {
524522 clear: right;
525523 float: right;
526 - border-width: .5em 0 .8em 1.4em;
 524+ margin: .5em 0 .8em 1.4em;
527525 }
528526 div.tleft {
529527 float: left;
530528 clear: left;
531 - margin-right: .5em;
532 - border-width: .5em 1.4em .8em 0;
 529+ margin: .5em 1.9em .8em 0;
533530 }
534531 img.thumbborder {
535532 border: 1px solid #dddddd;
Index: trunk/phase3/skins/vector/screen.css
@@ -892,8 +892,6 @@
893893 /* Thumbnails */
894894 div.thumb {
895895 margin-bottom: .5em;
896 - border-style: solid;
897 - border-color: transparent;
898896 width: auto;
899897 background-color: transparent;
900898 }
@@ -929,14 +927,13 @@
930928 div.tright {
931929 clear: right;
932930 float: right;
933 - border-width: .5em 0 .8em 1.4em;
 931+ margin: .5em 0 1.3em 1.4em;
934932 }
935933 /* @noflip */
936934 div.tleft {
937935 float: left;
938936 clear: left;
939 - margin-right: .5em;
940 - border-width: .5em 1.4em .8em 0;
 937+ margin: .5em 1.9em 1.3em 0;
941938 }
942939 img.thumbborder {
943940 border: 1px solid #dddddd;

Follow-up revisions

RevisionCommit summaryAuthorDate
r79091* Follow-up r79087. Applying to other skins that have similar article styling...krinkle23:23, 27 December 2010
r821511.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,...catrope22:55, 14 February 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79010Removing ugly whitespace around thumbnails on a non-white background....krinkle22:57, 25 December 2010

Status & tagging log