r78344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78343‎ | r78344 | r78345 >
Date:23:51, 13 December 2010
Author:tparscal
Status:reverted
Tags:
Comment:
Fixed issue in r78104 where jquery.cookie wouldn't load properly. Changed the mediaWiki User object to load jquery.cookie on demand.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
@@ -326,7 +326,6 @@
327327 'mediawiki' => array(
328328 'scripts' => 'resources/mediawiki/mediawiki.js',
329329 'debugScripts' => 'resources/mediawiki/mediawiki.log.js',
330 - 'dependencies' => array( 'jquery.cookie' ),
331330 'debugRaw' => false
332331 ),
333332 'mediawiki.util' => array(
Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -274,6 +274,7 @@
275275 if ( name ) {
276276 return name;
277277 }
 278+ mediaWiki.loader.load( 'jquery.cookie' );
278279 var sessionId = $.cookie( 'mediaWiki.user.sessionId' );
279280 if ( typeof sessionId == 'undefined' || sessionId == null ) {
280281 sessionId = generateSessionId();

Follow-up revisions

RevisionCommit summaryAuthorDate
r78347Fixes r78104 much better than r78344 did. By adding jquery.cookie to the load...tparscal00:02, 14 December 2010
r830371.17wmf1: Merge revs to mediawiki.js required by ArticleFeedback: r78104, r78...catrope19:23, 1 March 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011
r85343Fix for r85080: re-merge r78344, r78893, r78897, r78909demon17:13, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78104Added name and sessionId methods to user object - now anonymous users have an...tparscal23:18, 8 December 2010

Status & tagging log