r78350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78349‎ | r78350 | r78351 >
Date:00:08, 14 December 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added comment about why you should not be depending on mediaWiki.user.sessionId before mediaWiki.loader.go is called.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -328,6 +328,10 @@
329329 * Gets the current user's name or a random session ID automatically generated and kept in
330330 * a cookie.
331331 *
 332+ * Do not use this method before the first call to mediaWiki.loader.go(), it depends on
 333+ * jquery.cookie, which is added to the first payload just after mediaWiki is defined, but
 334+ * won't be loaded until the first call to go().
 335+ *
332336 * @return string user name or random session ID
333337 */
334338 this.sessionId = function () {

Follow-up revisions

RevisionCommit summaryAuthorDate
r830371.17wmf1: Merge revs to mediawiki.js required by ArticleFeedback: r78104, r78...catrope19:23, 1 March 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011

Status & tagging log