r78380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78379‎ | r78380 | r78381 >
Date:15:44, 14 December 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix up few remaining fixme things from r69910
Modified paths:
  • /trunk/phase3/includes/media/Bitmap_ClientOnly.php (modified) (history)
  • /trunk/phase3/includes/revisiondelete/RevisionDelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/revisiondelete/RevisionDelete.php
@@ -220,7 +220,7 @@
221221 */
222222 class RevDel_ArchiveItem extends RevDel_RevisionItem {
223223 public function __construct( $list, $row ) {
224 - parent::__construct( $list, $row );
 224+ RevDel_Item::__construct( $list, $row );
225225 $this->revision = Revision::newFromArchiveRow( $row,
226226 array( 'page' => $this->list->title->getArticleId() ) );
227227 }
@@ -526,7 +526,7 @@
527527 */
528528 class RevDel_ArchivedFileItem extends RevDel_FileItem {
529529 public function __construct( $list, $row ) {
530 - parent::__construct( $list, $row );
 530+ RevDel_Item::__construct( $list, $row );
531531 $this->file = ArchivedFile::newFromRow( $row );
532532 }
533533
Index: trunk/phase3/includes/media/Bitmap_ClientOnly.php
@@ -16,7 +16,7 @@
1717 */
1818 class BitmapHandler_ClientOnly extends BitmapHandler {
1919 function normaliseParams( $image, &$params ) {
20 - return parent::normaliseParams( $image, $params );
 20+ return ImageHandler::normaliseParams( $image, $params );
2121 }
2222
2323 function doTransform( $image, $dstPath, $dstUrl, $params, $flags = 0 ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r83417MFT r78380demon23:13, 6 March 2011
r85080MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, r...demon19:09, 31 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69910Change some more to parent::reedy21:02, 25 July 2010

Comments

#Comment by Bawolff (talk | contribs)   23:05, 6 March 2011

Tagging 1.17 since this revision fixes bug 27822 (rev deleting a file throws an exception)

Status & tagging log