r26015 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26014‎ | r26015 | r26016 >
Date:21:05, 21 September 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 25932-26011 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r25933 | siebrand | 2007-09-19 03:41:28 -0700 (Wed, 19 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* dsb (new).
........
r25935 | aaron | 2007-09-19 07:10:38 -0700 (Wed, 19 Sep 2007) | 1 line

*Revert bogus code from r24419. indexOf() is meant for Strings, not arrays. If used on such, it dies miserably in IE.
........
r25936 | siebrand | 2007-09-19 07:21:42 -0700 (Wed, 19 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* ar, bg, bi (new), br, csb, el, ext, frc, frp, gl, hak.
........
r25938 | brion | 2007-09-19 07:44:50 -0700 (Wed, 19 Sep 2007) | 4 lines

Tweaks to r25923 for my own peace of mind:
* De-escape & to & rather than & to & -- guarantees that we won't leave stray &s around producing invalid or freaky output
* Use == instead of = when comparing... :)
........
r25939 | brion | 2007-09-19 07:51:02 -0700 (Wed, 19 Sep 2007) | 2 lines

Tweak it up a little more -- also unescape the double-escaped quotes and angle brackets to keep the help message legible, but move unescaping down below the XML metaformatting, so the mail samples don't get misformatted as if they were XML elements.
........
r25941 | siebrand | 2007-09-19 08:53:24 -0700 (Wed, 19 Sep 2007) | 5 lines

Fix URLs to:
* http://www.mediawiki.org/wiki/Manual:Configuration_settings
* http://www.mediawiki.org/wiki/Manual:FAQ
* http://lists.wikimedia.org/mailman/listinfo/mediawiki-announce
........
r25944 | daniel | 2007-09-19 13:04:48 -0700 (Wed, 19 Sep 2007) | 1 line

security fix (read-protection): use anon user privileges when checking what should be shown in the RC RSS feed. Previously, a 'privileged' version might have been cached and served to everyone.
........
r25945 | daniel | 2007-09-19 13:06:06 -0700 (Wed, 19 Sep 2007) | 1 line

implemented action=purge for RC RSS feed. Not sure how usefull that is in production, but it should easy the pain of debugging feed output.
........
r25952 | raymond | 2007-09-20 01:03:01 -0700 (Thu, 20 Sep 2007) | 1 line

* (bug 11151) Add descriptive <title> to revision history page
........
r25958 | raymond | 2007-09-20 09:33:45 -0700 (Thu, 20 Sep 2007) | 2 lines

* Add message 'year-month' to enable swap of year and month in input form of
Special:Contributions for languages which prefer month-year instead of the default year-month
........
r25959 | raymond | 2007-09-20 10:20:09 -0700 (Thu, 20 Sep 2007) | 1 line

fix typo from r25958. Thanks to Nikerabbit
........
r25966 | brion | 2007-09-20 10:54:38 -0700 (Thu, 20 Sep 2007) | 3 lines

Revert r25958 and r25959 for now.
Even if we wanted to make the order of fields in a form language-dependent (which I'm not very comfortable with), this seems an odd way to do it. It introduces an unnecessary HTML message which could be broken in interesting ways and generally strikes me as odd.
........
r25967 | nikerabbit | 2007-09-20 11:22:19 -0700 (Thu, 20 Sep 2007) | 2 lines

* Namespace translations for Sicilian (scn)
........
r25968 | siebrand | 2007-09-20 11:52:58 -0700 (Thu, 20 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am (new), ga, hsb, is, scn, tet, yi.
........
r25973 | raymond | 2007-09-20 12:49:02 -0700 (Thu, 20 Sep 2007) | 2 lines

* (bug 11409) Update Swedish translations
Patch by Lejonel
........
r25974 | brion | 2007-09-20 12:55:22 -0700 (Thu, 20 Sep 2007) | 2 lines

* (bug 4918) Clean up logic for email notification minor edit option. I haven't been able to reproduce the bug, though, so not sure if there's no effect or what. Seems to work equally before and after.
........
r25980 | siebrand | 2007-09-21 02:31:08 -0700 (Fri, 21 Sep 2007) | 2 lines

* Grammar for wikibooks in cs.
* Whitespace/tab fixes
........
r25981 | siebrand | 2007-09-21 02:33:41 -0700 (Fri, 21 Sep 2007) | 1 line

Updates for name change of Czech Wiktionary
........
r25982 | huji | 2007-09-21 04:18:37 -0700 (Fri, 21 Sep 2007) | 1 line
........
r25990 | nikerabbit | 2007-09-21 07:17:56 -0700 (Fri, 21 Sep 2007) | 2 lines

* Messages and date formats for Ancient Greece (grc)
........
r25992 | nikerabbit | 2007-09-21 07:32:26 -0700 (Fri, 21 Sep 2007) | 2 lines

* Some cleanups that have been hanging here too long
........
r26007 | siebrand | 2007-09-21 11:22:03 -0700 (Fri, 21 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am, bat-smg, bn, ca, cs, dsb, is, tet.
........
r26009 | siebrand | 2007-09-21 11:43:16 -0700 (Fri, 21 Sep 2007) | 1 line

Fix 3 URLs
........
r26010 | siebrand | 2007-09-21 12:30:18 -0700 (Fri, 21 Sep 2007) | 1 line

property eol-style:native
........
r26011 | nikerabbit | 2007-09-21 12:37:07 -0700 (Fri, 21 Sep 2007) | 2 lines

* Cleanups
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/Linker.php (modified) (history)
  • /branches/liquidthreads/includes/PageHistory.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialRecentchanges.php (modified) (history)
  • /branches/liquidthreads/includes/UserMailer.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiFormatBase.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiMain.php (modified) (history)
  • /branches/liquidthreads/languages/Names.php (modified) (history)
  • /branches/liquidthreads/languages/classes/LanguageCs.php (modified) (history)
  • /branches/liquidthreads/languages/classes/LanguageDsb.php (added) (history)
  • /branches/liquidthreads/languages/classes/LanguageDsb.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesAm.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesAm.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesAr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesArn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBat_smg.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBg.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBi.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesBi.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesBn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCy.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDsb.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesDsb.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesEl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesExt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFrc.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFrp.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesGa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesGl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesGrc.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesGrc.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesHak.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesIs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKrj.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesMk.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNds.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesRo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSah.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesScn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSq.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSu.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSv.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesTa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesTet.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesVi.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesWar.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesYi.php (modified) (history)
  • /branches/liquidthreads/maintenance/language/messages.inc (modified) (history)
  • /branches/liquidthreads/skins/common/protect.js (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24419* (bug 10732) Protection chaining checkbox broken - this appears to have regr...robchurch23:09, 28 July 2007
r25923(bug 11296) Introduced special case pretty-printer rendering of the help docu...amidaniel22:10, 18 September 2007
r25933Localisation updates from Betawiki....siebrand10:41, 19 September 2007
r25935*Revert bogus code from r24419. indexOf() is meant for Strings, not arrays. I...aaron14:10, 19 September 2007
r25936Localisation updates from Betawiki....siebrand14:21, 19 September 2007
r25938Tweaks to r25923 for my own peace of mind:...brion14:44, 19 September 2007
r25939Tweak it up a little more -- also unescape the double-escaped quotes and angl...brion14:51, 19 September 2007
r25941Fix URLs to:...siebrand15:53, 19 September 2007
r25944security fix (read-protection): use anon user privileges when checking what s...daniel20:04, 19 September 2007
r25945implemented action=purge for RC RSS feed. Not sure how usefull that is in pro...daniel20:06, 19 September 2007
r25952* (bug 11151) Add descriptive <title> to revision history pageraymond08:03, 20 September 2007
r25958* Add message 'year-month' to enable swap of year and month in input form of...raymond16:33, 20 September 2007
r25959fix typo from r25958. Thanks to Nikerabbitraymond17:20, 20 September 2007
r25966Revert r25958 and r25959 for now....brion17:54, 20 September 2007
r25967* Namespace translations for Sicilian (scn)nikerabbit18:22, 20 September 2007
r25968Localisation updates from Betawiki....siebrand18:52, 20 September 2007
r25973* (bug 11409) Update Swedish translations...raymond19:49, 20 September 2007
r25974* (bug 4918) Clean up logic for email notification minor edit option. I haven...brion19:55, 20 September 2007
r25980* Grammar for wikibooks in cs....siebrand09:31, 21 September 2007
r25981Updates for name change of Czech Wiktionarysiebrand09:33, 21 September 2007
r25982huji11:18, 21 September 2007
r25990* Messages and date formats for Ancient Greece (grc)nikerabbit14:17, 21 September 2007
r25992* Some cleanups that have been hanging here too longnikerabbit14:32, 21 September 2007
r26007Localisation updates from Betawiki....siebrand18:22, 21 September 2007
r26009Fix 3 URLssiebrand18:43, 21 September 2007
r26010property eol-style:nativesiebrand19:30, 21 September 2007
r26011* Cleanupsnikerabbit19:37, 21 September 2007

Status & tagging log