r25974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25973‎ | r25974 | r25975 >
Date:19:55, 20 September 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 4918) Clean up logic for email notification minor edit option. I haven't been able to reproduce the bug, though, so not sure if there's no effect or what. Seems to work equally before and after.
Modified paths:
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
@@ -347,12 +347,15 @@
348348 $wuser = $dbr->fetchObject( $res );
349349 $watchingUser->setID($wuser->wl_user);
350350
351 - if ( ( $enotifwatchlistpage && $watchingUser->getOption('enotifwatchlistpages') ) ||
352 - ( $enotifusertalkpage
353 - && $watchingUser->getOption('enotifusertalkpages')
354 - && $title->equals( $watchingUser->getTalkPage() ) )
355 - && (!$minorEdit || ($wgEnotifMinorEdits && $watchingUser->getOption('enotifminoredits') ) )
356 - && ($watchingUser->isEmailConfirmed() ) ) {
 351+ if ( ( ( $enotifwatchlistpage
 352+ && $watchingUser->getOption('enotifwatchlistpages') )
 353+ || ( $enotifusertalkpage
 354+ && $watchingUser->getOption('enotifusertalkpages')
 355+ && $title->equals( $watchingUser->getTalkPage() ) ) )
 356+ && ( !$minorEdit
 357+ || ( $wgEnotifMinorEdits
 358+ && $watchingUser->getOption('enotifminoredits') ) )
 359+ && ( $watchingUser->isEmailConfirmed() ) ) {
357360 # ... adjust remaining text and page edit time placeholders
358361 # which needs to be personalized for each user
359362 if ($wgEnotifImpersonal)

Follow-up revisions

RevisionCommit summaryAuthorDate
r26015Merged revisions 25932-26011 via svnmerge from...david21:05, 21 September 2007

Status & tagging log