r25966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25965‎ | r25966 | r25967 >
Date:17:54, 20 September 2007
Author:brion
Status:old
Tags:
Comment:
Revert r25958 and r25959 for now.
Even if we wanted to make the order of fields in a form language-dependent (which I'm not very comfortable with), this seems an odd way to do it. It introduces an unnecessary HTML message which could be broken in interesting ways and generally strikes me as odd.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1290,7 +1290,6 @@
12911291 'uctop',
12921292 'month',
12931293 'year',
1294 - 'year-month',
12951294 ),
12961295 'sp-contributions' => array(
12971296 'sp-contributions-newest',
@@ -2397,8 +2396,7 @@
23982397 'exif-orientation-6' => '0th row: right; 0th column: top',
23992398 'exif-orientation-7' => '0th row: right; 0th column: bottom',
24002399 'exif-orientation-8' => '0th row: left; 0th column: bottom',
2401 - 'movepage-moved' => 'The two titles are passed in plain text as $3 and $4 to allow additional goodies in the message.',
2402 - 'year-month' => '$1 year, $2 month',
 2400+ 'movepage-moved' => 'The two titles are passed in plain text as $3 and $4 to allow additional goodies in the message.'
24032401 );
24042402
24052403 /** Messages which contain dollar signs (which are not followed by numbers), and therefore should use a single apostrophe */
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -205,7 +205,6 @@
206206 'filedelete-backlink',
207207 'pagetitle',
208208 'filename-prefix-blacklist',
209 - 'year-month',
210209 );
211210
212211 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/SpecialContributions.php
@@ -420,16 +420,8 @@
421421 }
422422 $f .= "\t" . Xml::hidden( $name, $value ) . "\n";
423423 }
424 - $inputMonth= '<span style="white-space: nowrap">' .
425 - Xml::label( wfMsg( 'month' ), 'month' ) . ' '.
426 - Xml::monthSelector( $options['month'], -1 ) . ' '.
427 - '</span>';
428 - $inputYear = '<span style="white-space: nowrap">' .
429 - Xml::label( wfMsg( 'year' ), 'year' ) . ' '.
430 - Xml::input( 'year', 4, $options['year'], array('id' => 'year', 'maxlength' => 4 ) ) .
431 - '</span>';
432424
433 - $f .= Xml::openElement( 'fieldset' ) .
 425+ $f .= '<fieldset>' .
434426 Xml::element( 'legend', array(), wfMsg( 'sp-contributions-search' ) ) .
435427 Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parseinline' ) ), 'contribs' , 'newbie' , 'newbie', $options['contribs'] == 'newbie' ? true : false ) . '<br />' .
436428 Xml::radioLabel( wfMsgExt( 'sp-contributions-username', array( 'parseinline' ) ), 'contribs' , 'user', 'user', $options['contribs'] == 'user' ? true : false ) . ' ' .
@@ -439,15 +431,23 @@
440432 Xml::namespaceSelector( $options['namespace'], '' ) .
441433 '</span>' .
442434 Xml::openElement( 'p' ) .
443 - wfMsg( 'year-month', $inputYear, $inputMonth ) . ' ' .
 435+ '<span style="white-space: nowrap">' .
 436+ Xml::label( wfMsg( 'year' ), 'year' ) . ' '.
 437+ Xml::input( 'year', 4, $options['year'], array('id' => 'year', 'maxlength' => 4) ) .
 438+ '</span>' .
 439+ ' '.
 440+ '<span style="white-space: nowrap">' .
 441+ Xml::label( wfMsg( 'month' ), 'month' ) . ' '.
 442+ Xml::monthSelector( $options['month'], -1 ) . ' '.
 443+ '</span>' .
444444 Xml::submitButton( wfMsg( 'sp-contributions-submit' ) ) .
445445 Xml::closeElement( 'p' );
446 -
 446+
447447 $explain = wfMsgExt( 'sp-contributions-explain', 'parseinline' );
448448 if( !wfEmptyMsg( 'sp-contributions-explain', $explain ) )
449449 $f .= "<p>{$explain}</p>";
450 -
451 - $f .= Xml::closeElement( 'fieldset' ) .
 450+
 451+ $f .= '</fieldset>' .
452452 Xml::closeElement( 'form' );
453453 return $f;
454454 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1971,7 +1971,6 @@
19721972 'uctop' => ' (top)',
19731973 'month' => 'From month (and earlier):',
19741974 'year' => 'From year (and earlier):',
1975 -'year-month' => '$1 $2', # $1 year, $2 month; only translate this message to other languages if you have to change it
19761975
19771976 'sp-contributions-newest' => 'Newest',
19781977 'sp-contributions-oldest' => 'Oldest',
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -1569,10 +1569,9 @@
15701570 'nocontribs' => 'Es wurden keine Benutzerbeiträge mit diesen Kriterien gefunden.',
15711571 'ucnote' => 'Dies sind die letzten <b>$1</b> Beiträge des Benutzers in den letzten <b>$2</b> Tagen.',
15721572 'uclinks' => 'Zeige die letzten $1 Beiträge; zeige die letzten $2 Tage.',
1573 -'uctop' => '(aktuell)',
1574 -'month' => 'Bis Monat:',
1575 -'year' => 'und Jahr:',
1576 -'year-month' => '$2 $1',
 1573+'uctop' => ' (aktuell)',
 1574+'month' => 'und Monat:',
 1575+'year' => 'bis Jahr:',
15771576
15781577 'sp-contributions-newest' => 'Jüngste',
15791578 'sp-contributions-oldest' => 'Älteste',
Index: trunk/phase3/RELEASE-NOTES
@@ -27,8 +27,6 @@
2828 * (bug 11136) If using Postgres, search path is explicitly set if wgDBmwschema is
2929 not set to 'mediawiki', allowing multiple mediawiki instances per user.
3030 * (bug 11151) Add descriptive <title> to revision history page
31 -* Add message 'year-month' to enable swap of year and month in input form of
32 - Special:Contributions
3331
3432 === Bug fixes in 1.12 ===
3533

Follow-up revisions

RevisionCommit summaryAuthorDate
r26015Merged revisions 25932-26011 via svnmerge from...david21:05, 21 September 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25958* Add message 'year-month' to enable swap of year and month in input form of...raymond16:33, 20 September 2007
r25959fix typo from r25958. Thanks to Nikerabbitraymond17:20, 20 September 2007

Status & tagging log