r25530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25529‎ | r25530 | r25531 >
Date:08:28, 5 September 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 25454-25529 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r25456 | catrope | 2007-09-03 12:58:05 -0700 (Mon, 03 Sep 2007) | 3 lines

* (bug 11115) API: Adding the SHA1 to the imageinfo query
* Moving misplaced entry in RELEASE-NOTES
........
r25457 | catrope | 2007-09-03 13:17:53 -0700 (Mon, 03 Sep 2007) | 2 lines

(bug 10898) API does not return an edit token for non-existent pages
........
r25459 | catrope | 2007-09-03 13:37:42 -0700 (Mon, 03 Sep 2007) | 3 lines

* (bug 10890) API: Timestamp support for categorymembers query
* Removed some stray whitespace
........
r25460 | rotem | 2007-09-03 13:38:14 -0700 (Mon, 03 Sep 2007) | 1 line

Update.
........
r25461 | tstarling | 2007-09-03 14:35:27 -0700 (Mon, 03 Sep 2007) | 1 line

Return an error message if the requested size was bigger than the source, or more generally if the "transformed" output file is in fact the source file.
........
r25463 | aaron | 2007-09-03 17:38:54 -0700 (Mon, 03 Sep 2007) | 1 line

*Allow for some non-patrollers to see which edits were patrolled
........
r25465 | tstarling | 2007-09-03 19:48:34 -0700 (Mon, 03 Sep 2007) | 1 line

Allow extensions to define magic words by simply including a $magicWords variable in their registered i18n file.
........
r25468 | aaron | 2007-09-03 21:13:53 -0700 (Mon, 03 Sep 2007) | 1 line

*Only sanitize IPv6 titles for pages in user namespace.
........
r25473 | brion | 2007-09-04 07:25:55 -0700 (Tue, 04 Sep 2007) | 2 lines

Use 'enc' variable naming convention for interpolated pre-encoded variables in raw SQL strings. This'll keep your release manager from freaking out when he sees raw variables being dumped into raw SQL.
........
r25474 | catrope | 2007-09-04 07:30:31 -0700 (Tue, 04 Sep 2007) | 2 lines

Additional fix of bug 10890
........
r25475 | brion | 2007-09-04 07:39:55 -0700 (Tue, 04 Sep 2007) | 3 lines

Revert '9' accesskey for prefs; remove bogus release notes line.
Numeric accesskeys interfere with things, among others the use of alt+numpad to type extended chars on Windows.
........
r25476 | catrope | 2007-09-04 07:44:46 -0700 (Tue, 04 Sep 2007) | 2 lines

(bug 10980) Add exclude redirects on backlinks
........
r25478 | aaron | 2007-09-04 08:05:08 -0700 (Tue, 04 Sep 2007) | 1 line

*Comment grammar
........
r25479 | tstarling | 2007-09-04 08:13:55 -0700 (Tue, 04 Sep 2007) | 1 line

Moved removeBadFile() to the base class
........
r25481 | brion | 2007-09-04 08:56:30 -0700 (Tue, 04 Sep 2007) | 3 lines

Fix the fix in r25439, which incorrectly assumed that normalized extensions are the same length as their non-normalized forms. This isn't true: JPEG vs jpg for instance. :)
Additionally, makes the AJAX checks for non-exact matches work when an exact match isn't present; wfFindFile() checks local and shared repository, but returns no object if there isn't an exact match. Falling back to wfLocalFile() to get an object so the checks go through.
........
r25482 | brion | 2007-09-04 08:57:00 -0700 (Tue, 04 Sep 2007) | 2 lines

And remove some debug loggin :)
........
r25489 | raymond | 2007-09-04 10:14:47 -0700 (Tue, 04 Sep 2007) | 3 lines

* (bug 10367) Update Kazakh translations
Patch by AlefZet
* Removing BOMs from r24770
........
r25490 | siebrand | 2007-09-04 10:19:27 -0700 (Tue, 04 Sep 2007) | 17 lines

Localisation updates for MediaWiki core messages from Betawiki
* se (new) by Skuolfi
* eo by Tlustulimu
* fiu_vro by Võrok
* it by BrokenArrow
* lv by Yyy
* ms
* nl by SPQRobin, Siebrand
* pl by Wpedzich
* rmy by Desiphral
* sk by Helix84
* so by Mimursal
* ta by Mayooranathan
* yi by Yidel
* RELEASE-NOTES updated

Diffs checked by Raymond
........
r25501 | siebrand | 2007-09-04 11:51:17 -0700 (Tue, 04 Sep 2007) | 7 lines

Localisation updates for MediaWiki core messages from Betawiki
* Farsi (fa) by Huji
* Français Cadien (frc) (new) by RoyAlcatraz and JeanVoisin
* Kinaray-a (krj) (new) by RonaldPanaligan and Harvzsf
* Winaray (war) (new) by Harvzsf
* updated RELEASE-NOTES
........
r25502 | siebrand | 2007-09-04 11:57:53 -0700 (Tue, 04 Sep 2007) | 1 line

Fix some encoding issues in language names by substiting with ASCII look alikes.
........
r25503 | nikerabbit | 2007-09-04 12:02:35 -0700 (Tue, 04 Sep 2007) | 2 lines

* Added names for new languages recently committed
........
r25504 | siebrand | 2007-09-04 12:07:14 -0700 (Tue, 04 Sep 2007) | 2 lines

* Fixing unicode names
* Fix on language name
........
r25505 | raymond | 2007-09-04 12:19:59 -0700 (Tue, 04 Sep 2007) | 1 line

revert 25504. Something goes totally wrong.
........
r25506 | nikerabbit | 2007-09-04 12:29:47 -0700 (Tue, 04 Sep 2007) | 3 lines

* Inclusion of Special:Wantedpages now works again
........
r25510 | siebrand | 2007-09-04 13:15:22 -0700 (Tue, 04 Sep 2007) | 1 line

Updates to MessagesEo.php by Nike.
........
r25512 | aaron | 2007-09-04 15:02:37 -0700 (Tue, 04 Sep 2007) | 1 line

*IPv6 blurb
........
r25513 | siebrand | 2007-09-04 15:24:53 -0700 (Tue, 04 Sep 2007) | 2 lines

Localisation updates from Betawiki by Nike.
* Minor fixes to Messages for eo, fiu-vro, it, lv, ms, nl, rmy, and yi.
........
r25515 | simetrical | 2007-09-04 17:47:54 -0700 (Tue, 04 Sep 2007) | 1 line

Revert 25502. We use UTF-8, not ASCII lookalikes. If your text editor doesn't support UTF-8, please fix it. Also, fixed one ISO 8859 character that snuck in (which might have messed up the relevant text editor to start with).
........
r25519 | siebrand | 2007-09-04 23:08:30 -0700 (Tue, 04 Sep 2007) | 1 line

Fallback language was supposed to be English (removed French)
........
r25525 | midom | 2007-09-05 01:11:30 -0700 (Wed, 05 Sep 2007) | 2 lines

be resourceful, instead of creating new indexing bloat, use existing indexes.
........
r25527 | midom | 2007-09-05 01:14:18 -0700 (Wed, 05 Sep 2007) | 2 lines

destroy rc_patrolling index, no removers added, I hope not that many people did run update with that revision :)
........
r25528 | aaron | 2007-09-05 01:20:24 -0700 (Wed, 05 Sep 2007) | 1 line

*Remove comment per r25527
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/ChangesList.php (modified) (history)
  • /branches/liquidthreads/includes/DifferenceEngine.php (modified) (history)
  • /branches/liquidthreads/includes/MessageCache.php (modified) (history)
  • /branches/liquidthreads/includes/QueryPage.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialUpload.php (modified) (history)
  • /branches/liquidthreads/includes/Title.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryCategoryMembers.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryInfo.php (modified) (history)
  • /branches/liquidthreads/includes/media/Generic.php (modified) (history)
  • /branches/liquidthreads/languages/Language.php (modified) (history)
  • /branches/liquidthreads/languages/Names.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFiu_vro.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFrc.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesFrc.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesHe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesIt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_cn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_kz.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKk_tr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKrj.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesKrj.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesLv.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesMs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesRmy.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSe.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesSe.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesSk.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesTa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesWar.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesWar.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesYi.php (modified) (history)
  • /branches/liquidthreads/maintenance/archives/patch-rc_patrol_index.sql (deleted) (history)
  • /branches/liquidthreads/maintenance/postgres/tables.sql (modified) (history)
  • /branches/liquidthreads/maintenance/tables.sql (modified) (history)
  • /branches/liquidthreads/maintenance/updaters.inc (modified) (history)
  • /branches/liquidthreads/thumb.php (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r25581API: Really fixing bug 10898 this timecatrope11:28, 6 September 2007
r25607Merged revisions 25530-25606 via svnmerge from...david06:11, 7 September 2007
r25622* (bug 10367) Update Kazakh translations...raymond09:20, 7 September 2007
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007
r26291* (bug 10367) Update Kazakh translations...raymond21:19, 1 October 2007
r26331Merged revisions 26280-26330 via svnmerge from...david22:28, 2 October 2007
r26935* (bug 10367) Kazakh message updates, by AlefZetraymond22:07, 24 October 2007
r27849* (bug 10367) Update Kazakh translations...raymond16:32, 26 November 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23472* (bug 10367) Update Kazakh translations...raymond10:35, 27 June 2007
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007
r24493* (bug 10367) Update Kazakh translations...raymond15:26, 31 July 2007
r24536* (bug 10367) Update Kazakh translations...raymond06:24, 2 August 2007
r24631Merged revisions 24480-24600 via svnmerge from...david18:39, 6 August 2007
r24710* (bug 10367) Update Kazakh translations...raymond20:46, 9 August 2007
r24739* (bug 10367) Update Kazakh translations...raymond07:52, 13 August 2007
r24755Merged revisions 24694-24754 via svnmerge from...david19:48, 13 August 2007
r24770* (bug 10367) Update Kazakh translations...raymond06:40, 14 August 2007
r24863* (bug 10367) Update Kazakh translations...raymond21:36, 16 August 2007
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007
r25112* (bug 10367) Update Kazakh translations...raymond08:01, 24 August 2007
r25126Merged revisions 25109-25125 via svnmerge from...david22:55, 24 August 2007
r25196* (bug 10367) Update Kazakh translations...raymond14:25, 27 August 2007
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007
r25439Fix a regression from the file repo stuff....raymond15:06, 3 September 2007
r25456* (bug 11115) API: Adding the SHA1 to the imageinfo query...catrope19:58, 3 September 2007
r25457(bug 10898) API does not return an edit token for non-existent pagescatrope20:17, 3 September 2007
r25458apiedit: Fixing bug 10898 the dirty way, will clean up QueryInfo later.catrope20:19, 3 September 2007
r25459* (bug 10890) API: Timestamp support for categorymembers query...catrope20:37, 3 September 2007
r25460Update.rotem20:38, 3 September 2007
r25461Return an error message if the requested size was bigger than the source, or ...tstarling21:35, 3 September 2007
r25463*Allow for some non-patrollers to see which edits were patrolledaaron00:38, 4 September 2007
r25465Allow extensions to define magic words by simply including a $magicWords vari...tstarling02:48, 4 September 2007
r25468*Only sanitize IPv6 titles for pages in user namespace.aaron04:13, 4 September 2007
r25473Use 'enc' variable naming convention for interpolated pre-encoded variables i...brion14:25, 4 September 2007
r25474Additional fix of bug 10890catrope14:30, 4 September 2007
r25475Revert '9' accesskey for prefs; remove bogus release notes line....brion14:39, 4 September 2007
r25476(bug 10980) Add exclude redirects on backlinkscatrope14:44, 4 September 2007
r25478*Comment grammaraaron15:05, 4 September 2007
r25479Moved removeBadFile() to the base clasststarling15:13, 4 September 2007
r25481Fix the fix in r25439, which incorrectly assumed that normalized extensions a...brion15:56, 4 September 2007
r25482And remove some debug loggin :)brion15:57, 4 September 2007
r25489* (bug 10367) Update Kazakh translations...raymond17:14, 4 September 2007
r25490Localisation updates for MediaWiki core messages from Betawiki...siebrand17:19, 4 September 2007
r25501Localisation updates for MediaWiki core messages from Betawiki...siebrand18:51, 4 September 2007
r25502Fix some encoding issues in language names by substiting with ASCII look alikes.siebrand18:57, 4 September 2007
r25503* Added names for new languages recently committednikerabbit19:02, 4 September 2007
r25504* Fixing unicode names...siebrand19:07, 4 September 2007
r25505revert 25504. Something goes totally wrong.raymond19:19, 4 September 2007
r25506* Inclusion of Special:Wantedpages now works againnikerabbit19:29, 4 September 2007
r25510Updates to MessagesEo.php by Nike.siebrand20:15, 4 September 2007
r25512*IPv6 blurbaaron22:02, 4 September 2007
r25513Localisation updates from Betawiki by Nike....siebrand22:24, 4 September 2007
r25515Revert 25502. We use UTF-8, not ASCII lookalikes. If your text editor doesn...simetrical00:47, 5 September 2007
r25519Fallback language was supposed to be English (removed French)siebrand06:08, 5 September 2007
r25525be resourceful, instead of creating new indexing bloat, use existing indexes.midom08:11, 5 September 2007
r25527destroy rc_patrolling index, no removers added, I hope not that many people d...midom08:14, 5 September 2007
r25528*Remove comment per r25527aaron08:20, 5 September 2007

Status & tagging log