r25482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25481‎ | r25482 | r25483 >
Date:15:57, 4 September 2007
Author:brion
Status:old
Tags:
Comment:
And remove some debug loggin :)
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -459,7 +459,6 @@
460460 // Check for uppercase extension. We allow these filenames but check if an image
461461 // with lowercase extension exists already
462462 $warning = '';
463 - wfDebugLog( 'borko', 'wtf' );
464463
465464 if( strpos( $file->getName(), '.' ) == false ) {
466465 $partname = $file->getName();
@@ -467,7 +466,6 @@
468467 } else {
469468 list( $partname, $rawExtension ) = explode( '.', $file->getName(), 2 );
470469 }
471 - wfDebugLog( 'borko', sprintf( "%s - %s - %s", $partname, $rawExtension, $file->getExtension() ) );
472470 $sk = $wgUser->getSkin();
473471
474472 if ( $rawExtension != $file->getExtension() ) {
@@ -478,14 +476,8 @@
479477 // Check for another file using the normalized form...
480478 $nt_lc = Title::newFromText( $partname . '.' . $file->getExtension() );
481479 $file_lc = wfLocalFile( $nt_lc );
482 - if( $file_lc ) {
483 - wfDebugLog( 'borko', 'whee: ' . $file_lc->getName() );
484 - } else {
485 - wfDebugLog( 'borko', 'no lc match');
486 - }
487480 } else {
488481 $file_lc = false;
489 - wfDebugLog( 'borko', 'extensions ok');
490482 }
491483
492484 if( $file->exists() ) {
@@ -504,7 +496,6 @@
505497 $warning .= '<li>' . wfMsgExt( 'fileexists', 'parseline', $dlink ) . '</li>' . $dlink2;
506498
507499 } elseif ( $file_lc && $file_lc->exists() ) {
508 - wfDebugLog( 'borko', 'whee: ' . $file_lc->getName() );
509500 # Check if image with lowercase extension exists.
510501 # It's not forbidden but in 99% it makes no sense to upload the same filename with uppercase extension
511502 $dlink = $sk->makeKnownLinkObj( $nt_lc );

Follow-up revisions

RevisionCommit summaryAuthorDate
r25530Merged revisions 25454-25529 via svnmerge from...david08:28, 5 September 2007

Status & tagging log