r25456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25455‎ | r25456 | r25457 >
Date:19:58, 3 September 2007
Author:catrope
Status:old
Tags:
Comment:
* (bug 11115) API: Adding the SHA1 to the imageinfo query
* Moving misplaced entry in RELEASE-NOTES
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -50,6 +50,7 @@
5151 $fld_comment = isset($prop['comment']);
5252 $fld_url = isset($prop['url']);
5353 $fld_size = isset($prop['size']);
 54+ $fld_sha1 = isset($prop['sha1']);
5455
5556 $pageIds = $this->getPageSet()->getAllTitlesByNamespace();
5657 if (!empty($pageIds[NS_IMAGE])) {
@@ -87,6 +88,9 @@
8889 $vals['url'] = $isCur ? $img->getURL() : $img->getArchiveUrl($row["oi_archive_name"]);
8990 if ($fld_comment)
9091 $vals['comment'] = $row["{$prefix}_description"];
 92+
 93+ if ($fld_sha1)
 94+ $vals['sha1'] = wfBaseConvert($row["{$prefix}_sha1"], 36, 16, 40);
9195
9296 $data[] = $vals;
9397
@@ -119,6 +123,7 @@
120124 'comment',
121125 'url',
122126 'size',
 127+ 'sha1'
123128 )
124129 ),
125130 'history' => false,
Index: trunk/phase3/RELEASE-NOTES
@@ -427,7 +427,6 @@
428428 * Preventing the TOC from appearing in Special:Statistics
429429 * (bug 11082) Fix check for fully-specced table names in Database::tableName
430430 * (bug 11067) Fix regression in upload conflict thumbnail display
431 -* (bug 11072) Fix regression in API image history query
432431 * (bug 10985) Resolved cached entries on Special:DoubleRedirects were being
433432 supressed, breaking paging - now strikes out "fixed" results
434433 * (bug 8393) <sup> and <sub> need to be preserved (without attributes) for
@@ -495,6 +494,8 @@
496495 * Treat underscores as spaces for `aufrom` and `auprefix` parameters
497496 * Added edit/delete/... token retrieval to prop=info
498497 * Added meta=userinfo - logged-in user information, group membership, rights
 498+* (bug 11072) Fix regression in API image history query
 499+* (bug 11115) Adding SHA1 hash to imageinfo query
499500
500501 == Maintenance script changes since 1.10 ==
501502

Follow-up revisions

RevisionCommit summaryAuthorDate
r25530Merged revisions 25454-25529 via svnmerge from...david08:28, 5 September 2007

Status & tagging log