r108622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108621‎ | r108622 | r108623 >
Date:15:04, 11 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/OutputPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Skin.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/parser/Parser.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/mediawiki.action/mediawiki.action.edit.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/parser/Parser.php
@@ -3781,8 +3781,9 @@
37823782
37833783 # Inhibit editsection links if requested in the page
37843784 if ( isset( $this->mDoubleUnderscores['noeditsection'] ) ) {
3785 - $showEditLink = 0;
 3785+ $maybeShowEditLink = $showEditLink = false;
37863786 } else {
 3787+ $maybeShowEditLink = true; /* Actual presence will depend on ParserOptions option */
37873788 $showEditLink = $this->mOptions->getEditSection();
37883789 }
37893790 if ( $showEditLink ) {
@@ -4037,7 +4038,7 @@
40384039 );
40394040
40404041 # give headline the correct <h#> tag
4041 - if ( $sectionIndex !== false ) {
 4042+ if ( $maybeShowEditLink && $sectionIndex !== false ) {
40424043 // Output edit section links as markers with styles that can be customized by skins
40434044 if ( $isTemplate ) {
40444045 # Put a T flag in the section identifier, to indicate to extractSections()
Property changes on: branches/wmf/1.18wmf1/includes/parser/Parser.php
___________________________________________________________________
Modified: svn:mergeinfo
40454046 Merged /trunk/phase3/includes/parser/Parser.php:r100756,103074
Index: branches/wmf/1.18wmf1/includes/OutputPage.php
@@ -1223,6 +1223,7 @@
12241224 public function parserOptions( $options = null ) {
12251225 if ( !$this->mParserOptions ) {
12261226 $this->mParserOptions = new ParserOptions;
 1227+ $this->mParserOptions->setEditSection( false );
12271228 }
12281229 return wfSetVar( $this->mParserOptions, $options );
12291230 }
Property changes on: branches/wmf/1.18wmf1/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
12301231 Merged /trunk/phase3/includes/OutputPage.php:r92703
Index: branches/wmf/1.18wmf1/includes/Skin.php
@@ -435,7 +435,6 @@
436436 * @return String
437437 */
438438 function getPageClasses( $title ) {
439 - global $wgRequest;
440439 $numeric = 'ns-' . $title->getNamespace();
441440
442441 if ( $title->getNamespace() == NS_SPECIAL ) {
@@ -454,13 +453,8 @@
455454 }
456455
457456 $name = Sanitizer::escapeClass( 'page-' . $title->getPrefixedText() );
458 -
459 - if ( $wgRequest->getVal('action') ) {
460 - $action = 'action-' . $wgRequest->getVal('action');
461 - } else {
462 - $action = 'action-view';
463 - }
464 - return "$numeric $type $name $action";
 457+
 458+ return "$numeric $type $name";
465459 }
466460
467461 /**
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
468462 Merged /trunk/phase3/includes:r92703,94131,100756,103074,107623
Index: branches/wmf/1.18wmf1/resources/mediawiki.action/mediawiki.action.edit.js
@@ -85,7 +85,7 @@
8686 // Create button bar
8787 mw.toolbar.init();
8888
89 - $( '#wpSummary, #wpTextbox1' ).focus( function() {
 89+ $( 'textarea, input:text' ).focus( function() {
9090 currentFocused = $(this);
9191 });
9292
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
9393 Merged /trunk/phase3:r92703,94131,100756,103074,107623

Follow-up revisions

RevisionCommit summaryAuthorDate
r108626Revert r108345 out of r108625, also revert r94131 out of r108622reedy15:37, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92703(bug 25355) Parser generates edit section links for special pages...demon22:32, 20 July 2011
r94131Reverted r91871 per CR: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/......aaron18:36, 9 August 2011
r100756If the page contains __NOEDITSECTION__, it will never have edit sections, so ...platonides22:18, 25 October 2011
r103074Make sure that the old insertTags of mediawiki.action.edit.js works with each...hartman23:28, 14 November 2011
r107623(bug 31469) Make sure tracking category messages expand variables like...bawolff06:44, 30 December 2011

Comments

#Comment by Reedy (talk | contribs)   23:47, 12 January 2012

Status & tagging log