r92703 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92702‎ | r92703 | r92704 >
Date:22:32, 20 July 2011
Author:demon
Status:ok (Comments)
Tags:needs-php-test 
Comment:
(bug 25355) Parser generates edit section links for special pages

Per Tim on r58362: disable edit section links on all text parsed via $wgOut. Article already handles setting this to true for page content, so this shouldn't really hurt anything. Could use some tests to confirm the behavior, however. Should resolve the last problems with r70498 and friends.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -23,6 +23,7 @@
2424 * $wgUploadNavigationUrl should be used for file redlinks if
2525 $wgUploadMissingFileUrl is not set. The first was used for this
2626 until the second was introduced in 1.17.
 27+* (bug 25355) Parser generates edit section links for special pages
2728
2829 === API changes in 1.19 ===
2930 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/OutputPage.php
@@ -1279,6 +1279,7 @@
12801280 public function parserOptions( $options = null ) {
12811281 if ( !$this->mParserOptions ) {
12821282 $this->mParserOptions = new ParserOptions;
 1283+ $this->mParserOptions->setEditSection( false );
12831284 }
12841285 return wfSetVar( $this->mParserOptions, $options );
12851286 }

Sign-offs

UserFlagDate
Catropeinspected23:05, 20 July 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r108620MFT r92703, r94131...reedy14:53, 11 January 2012
r108621Kill bug 25355 RELEASE-NOTES-1.19 from r92703 as moved to 1.18 in r108620reedy14:53, 11 January 2012
r108622MFT r92703, r94131, r100756, r103074, r107623reedy15:04, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58362Remove section edit links in edit conflict form pointing nowhere useful and o...catrope14:30, 30 October 2009
r70498Change quickUserCan( 'edit' ) and getIsPrintable() into setEditSection( false )...platonides14:37, 5 August 2010

Comments

#Comment by Nikerabbit (talk | contribs)   10:54, 11 January 2012

I assume it is this revision that fixes all those annoying [edit] section links on special pages. Tagging for merging.

Status & tagging log