r108626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108625‎ | r108626 | r108627 >
Date:15:37, 11 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Revert r108345 out of r108625, also revert r94131 out of r108622
Modified paths:
  • /branches/wmf/1.18wmf1/includes/OutputPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/OutputPage.php
@@ -2227,8 +2227,7 @@
22282228 * @return String: The doctype, opening <html>, and head element.
22292229 */
22302230 public function headElement( Skin $sk, $includeStyle = true ) {
2231 - global $wgContLang, $wgUseTrackbacks, $mediaWiki;
2232 -
 2231+ global $wgContLang, $wgUseTrackbacks;
22332232 $userdir = $this->getLang()->getDir();
22342233 $sitedir = $wgContLang->getDir();
22352234
@@ -2292,7 +2291,6 @@
22932292 }
22942293 $bodyAttrs['class'] .= ' ' . $sk->getPageClasses( $this->getTitle() );
22952294 $bodyAttrs['class'] .= ' skin-' . Sanitizer::escapeClass( $sk->getSkinName() );
2296 - $bodyAttrs['class'] .= ' action-' . Sanitizer::escapeClass( $mediaWiki->getPerformedAction() );
22972295
22982296 $sk->addToBodyAttributes( $this, $bodyAttrs ); // Allow skins to add body attributes they need
22992297 wfRunHooks( 'OutputPageBodyAttributes', array( $this, $sk, &$bodyAttrs ) );
Property changes on: branches/wmf/1.18wmf1/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
23002298 Reverse-merged /trunk/phase3/includes/OutputPage.php:r108345
Index: branches/wmf/1.18wmf1/includes/Skin.php
@@ -435,6 +435,7 @@
436436 * @return String
437437 */
438438 function getPageClasses( $title ) {
 439+ global $wgRequest;
439440 $numeric = 'ns-' . $title->getNamespace();
440441
441442 if ( $title->getNamespace() == NS_SPECIAL ) {
@@ -453,8 +454,13 @@
454455 }
455456
456457 $name = Sanitizer::escapeClass( 'page-' . $title->getPrefixedText() );
457 -
458 - return "$numeric $type $name";
 458+
 459+ if ( $wgRequest->getVal('action') ) {
 460+ $action = 'action-' . $wgRequest->getVal('action');
 461+ } else {
 462+ $action = 'action-view';
 463+ }
 464+ return "$numeric $type $name $action";
459465 }
460466
461467 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94131Reverted r91871 per CR: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/......aaron18:36, 9 August 2011
r108345[Skin] Add CSS hook for action ("action-.." class on body)...krinkle01:49, 8 January 2012
r108622MFT r92703, r94131, r100756, r103074, r107623reedy15:04, 11 January 2012
r108625MFT r108345, r108145 without tests/release-notesreedy15:31, 11 January 2012

Status & tagging log