r94131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94130‎ | r94131 | r94132 >
Date:18:36, 9 August 2011
Author:aaron
Status:ok (Comments)
Tags:bug27930 
Comment:
Reverted r91871 per CR: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19474

Also, the related getAction() changes were already reverted.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -352,7 +352,6 @@
353353 * @return String
354354 */
355355 function getPageClasses( $title ) {
356 - global $wgRequest;
357356 $numeric = 'ns-' . $title->getNamespace();
358357
359358 if ( $title->getNamespace() == NS_SPECIAL ) {
@@ -371,13 +370,8 @@
372371 }
373372
374373 $name = Sanitizer::escapeClass( 'page-' . $title->getPrefixedText() );
375 -
376 - if ( $wgRequest->getVal('action') ) {
377 - $action = 'action-' . $wgRequest->getVal('action');
378 - } else {
379 - $action = 'action-view';
380 - }
381 - return "$numeric $type $name $action";
 374+
 375+ return "$numeric $type $name";
382376 }
383377
384378 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r108345[Skin] Add CSS hook for action ("action-.." class on body)...krinkle01:49, 8 January 2012
r108620MFT r92703, r94131...reedy14:53, 11 January 2012
r108622MFT r92703, r94131, r100756, r103074, r107623reedy15:04, 11 January 2012
r108626Revert r108345 out of r108625, also revert r94131 out of r108622reedy15:37, 11 January 2012
r108627Revert r94131 out of 1.18 from r108620reedy15:40, 11 January 2012
r108632Add @since to getPerformedAction, added in r108342...reedy15:51, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91871Add action-* class to body. Bug 4438. Based on patch by Subfaderdiebuche10:57, 11 July 2011

Comments

#Comment by Krinkle (talk | contribs)   01:37, 8 January 2012

This class was requested in bug 4438, re-opened.

#Comment by Krinkle (talk | contribs)   01:38, 8 January 2012

Note that this revert didn't make it into REL1_18, the bad way of getting action- class is in 1.18

#Comment by Krinkle (talk | contribs)   01:51, 8 January 2012

Don't merge without merging r108345 as well, other wise a regression occurs.

Status & tagging log