r103074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103073‎ | r103074 | r103075 >
Date:23:28, 14 November 2011
Author:hartman
Status:ok
Tags:
Comment:
Make sure that the old insertTags of mediawiki.action.edit.js works with each textarea or text input field on a page.

Note. Using input:text, because input[type=text] doesn't return the input's with no type set.

This fixes bug 31682, where Extension:CharInsert wasn't working on upload pages anymore and
bug 31566, where Extension:Proofread's header and footer fields didn't work icw CharInsert
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js
——@@ -85,7 +85,7 @@
8686 // Create button bar
8787 mw.toolbar.init();
8888
89 - $( '#wpSummary, #wpTextbox1' ).focus( function() {
 89+ $( 'textarea, input:text' ).focus( function() {
9090 currentFocused = $(this);
9191 });
9292

Follow-up revisions

RevisionCommit summaryAuthorDate
r103160REL1_18 MFT r102948, r103074, r103138reedy12:55, 15 November 2011
r108622MFT r92703, r94131, r100756, r103074, r107623reedy15:04, 11 January 2012

Status & tagging log