r108625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108624‎ | r108625 | r108626 >
Date:15:31, 11 January 2012
Author:reedy
Status:resolved
Tags:
Comment:
MFT r108345, r108145 without tests/release-notes
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/OutputPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/OutputPage.php
@@ -2227,7 +2227,8 @@
22282228 * @return String: The doctype, opening <html>, and head element.
22292229 */
22302230 public function headElement( Skin $sk, $includeStyle = true ) {
2231 - global $wgContLang, $wgUseTrackbacks;
 2231+ global $wgContLang, $wgUseTrackbacks, $mediaWiki;
 2232+
22322233 $userdir = $this->getLang()->getDir();
22332234 $sitedir = $wgContLang->getDir();
22342235
@@ -2291,6 +2292,7 @@
22922293 }
22932294 $bodyAttrs['class'] .= ' ' . $sk->getPageClasses( $this->getTitle() );
22942295 $bodyAttrs['class'] .= ' skin-' . Sanitizer::escapeClass( $sk->getSkinName() );
 2296+ $bodyAttrs['class'] .= ' action-' . Sanitizer::escapeClass( $mediaWiki->getPerformedAction() );
22952297
22962298 $sk->addToBodyAttributes( $this, $bodyAttrs ); // Allow skins to add body attributes they need
22972299 wfRunHooks( 'OutputPageBodyAttributes', array( $this, $sk, &$bodyAttrs ) );
Property changes on: branches/wmf/1.18wmf1/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
22982300 Merged /trunk/phase3/includes/OutputPage.php:r108345
Index: branches/wmf/1.18wmf1/includes/Skin.php
@@ -1238,6 +1238,12 @@
12391239 if ( strpos( $line, '|' ) !== false ) { // sanity check
12401240 $line = MessageCache::singleton()->transform( $line, false, null, $this->getTitle() );
12411241 $line = array_map( 'trim', explode( '|', $line, 2 ) );
 1242+ if ( count( $line ) !== 2 ) {
 1243+ // Second sanity check, could be hit by people doing
 1244+ // funky stuff with parserfuncs... (bug 3321)
 1245+ continue;
 1246+ }
 1247+
12421248 $extraAttribs = array();
12431249
12441250 $msgLink = wfMessage( $line[0] )->inContentLanguage();
@@ -1249,7 +1255,6 @@
12501256 } else {
12511257 $link = $line[0];
12521258 }
1253 -
12541259 $msgText = wfMessage( $line[1] );
12551260 if ( $msgText->exists() ) {
12561261 $text = $msgText->text();
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
12571262 Merged /trunk/phase3/includes:r108145,108345
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
12581263 Merged /trunk/phase3:r108145,108345

Follow-up revisions

RevisionCommit summaryAuthorDate
r108626Revert r108345 out of r108625, also revert r94131 out of r108622reedy15:37, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108145(bug 33321. Sort of) Adding a line to MediaWiki:Sidebar that contains a pipe,...bawolff15:34, 5 January 2012
r108345[Skin] Add CSS hook for action ("action-.." class on body)...krinkle01:49, 8 January 2012

Status & tagging log