r108623 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108622‎ | r108623 | r108624 >
Date:15:16, 11 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.css (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.js (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5 (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -53,8 +53,8 @@
5454 'articlefeedbackv5-form-hide' => 'Hide this ($1)',
5555 'articlefeedbackv5-form-abuse' => 'Flag as abuse ($1)',
5656 'articlefeedbackv5-form-header' => 'Feedback #$1, at $2',
57 - 'articlefeedbackv5-form1-header-found' => '$1 found what they were looking for:',
58 - 'articlefeedbackv5-form1-header-not-found' => '$1 did not find what they were looking for:',
 57+ 'articlefeedbackv5-form1-header-found' => '{{GENDER:$1|$1}} found what they were looking for:',
 58+ 'articlefeedbackv5-form1-header-not-found' => '{{GENDER:$1|$1}} did not find what they were looking for:',
5959 'articlefeedbackv5-form2-header' => '$1 had a $2:',
6060 'articlefeedbackv5-form3-header' => '$1 rated this page $2/5',
6161 'articlefeedbackv5-form4-header' => 'User was presented with the CTA-only form.',
Property changes on: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5
___________________________________________________________________
Modified: svn:mergeinfo
6262 Merged /trunk/extensions/ArticleFeedbackv5:r107050,107337
Index: branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.js
@@ -398,6 +398,10 @@
399399 s = s.replace( /\n\s+\*?([^\n]*)/g, '\n<li>$1</li>' ); // <li> around bulleted lines
400400 }
401401 s = s.replace( /\n(?!<)/, '\n<br/>' );
 402+ s = s.replace( /(?:https?:)?\/\/[^\s<>]+/g, function( s ) {
 403+ // linkify URLs, input is already HTML-escaped above
 404+ return '<a href="' + s + '">' + s + '</a>';
 405+ } );
402406 return s;
403407 }
404408
Index: branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.css
@@ -36,3 +36,10 @@
3737 height: 15em;
3838 overflow: scroll;
3939 }
 40+
 41+/* override enwiki's insane styles */
 42+div.mw-collapsible {
 43+ border: none !important;
 44+ text-align: left !important;
 45+ font-size: 100% !important;
 46+}
Index: branches/wmf/1.18wmf1/extensions/CodeReview/CodeReview.i18n.php
@@ -92,6 +92,7 @@
9393 'code-rev-purge-link' => 'purge',
9494 'code-rev-total' => 'Total number of results: $1',
9595 'code-rev-not-found' => "Revision '''$1''' does not exist!",
 96+ 'code-rev-history-link' => 'history',
9697 'code-status-new' => 'new',
9798 'code-status-desc-new' => 'Revision is pending an action (default status).',
9899 'code-status-fixme' => 'fixme',
Index: branches/wmf/1.18wmf1/extensions/CodeReview/ui/CodeRevisionView.php
@@ -285,6 +285,10 @@
286286 $path = preg_replace( '/ \([^\)]+\)$/', '', $path );
287287 $viewvc = $this->mRepo->getViewVcBase();
288288 $diff = '';
 289+ $hist = $this->skin->link(
 290+ SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() ),
 291+ wfMsg( 'code-rev-history-link' ), array(), array( 'path' => $path )
 292+ );
289293 $safePath = wfUrlEncode( $path );
290294 if ( $viewvc ) {
291295 $rev = $this->mRev->getId();
@@ -312,7 +316,7 @@
313317 } else {
314318 $link = $safePath;
315319 }
316 - return "<li><b>$link</b> ($desc)$diff</li>\n";
 320+ return "<li><b>$link</b> ($desc) ($hist)$diff</li>\n";
317321 }
318322
319323 protected function tagForm() {
Property changes on: branches/wmf/1.18wmf1/extensions/CodeReview
___________________________________________________________________
Modified: svn:mergeinfo
320324 Merged /trunk/extensions/CodeReview:r95614,104865,105908,107050,107337
Property changes on: branches/wmf/1.18wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
321325 Merged /trunk/extensions:r95614,104865,105908,107050,107337

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95614Adds link to path history in modified paths sectionjohnduhart02:59, 28 August 2011
r104865Fight back enwiki's Common.css that was wreaking havoc in the "Generic parame...maxsem15:48, 1 December 2011
r105908ApiSandbox: linkify URLs in smartEscape()maxsem17:34, 12 December 2011
r107050Add gender support for two messages....siebrand09:56, 22 December 2011

Status & tagging log