r105799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105798‎ | r105799 | r105800 >
Date:15:39, 11 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
MFT r32957

Bug 32957 - ApiSandbox: action feedbackdashboard doesn't load
Modified paths:
  • /branches/wmf/1.18wmf1/extensions (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ApiSandbox/ext.apiSandbox.js
@@ -282,17 +282,6 @@
283283 return typeof x != 'undefined';
284284 }
285285
286 - /**
287 - * Merges several objects into one that gets returned
288 - */
289 - function merge( /* ... */ ) {
290 - var res = {};
291 - for ( var i = 0; i < arguments.length; i++ ) {
292 - $.extend( res, arguments[i] );
293 - }
294 - return res;
295 - }
296 -
297286 function showLoading( $element ) {
298287 $element.html(
299288 mw.html.element( 'img',
@@ -394,6 +383,9 @@
395384 * @return {String}
396385 */
397386 function smartEscape( s ) {
 387+ if ( !s ) {
 388+ return ''; // @todo: fully verify paraminfo output
 389+ }
398390 s = mw.html.escape( s );
399391 if ( s.indexOf( '\n ' ) >= 0 ) {
400392 // turns *-bulleted list into a HTML list
Property changes on: branches/wmf/1.18wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
401393 Merged /trunk/extensions:r104863

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104863ApiSandbox:...maxsem15:39, 1 December 2011

Comments

#Comment by Reedy (talk | contribs)   15:42, 11 December 2011

Fail, merge of r104863

Status & tagging log