r105016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105015‎ | r105016 | r105017 >
Date:22:31, 2 December 2011
Author:rsterbin
Status:deferred
Tags:
Comment:
Bug fix for expertise box not getting checked; added email to the data sent to the ajax call on submit
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -1325,7 +1325,7 @@
13261326 // Slide-down for the expertise checkboxes
13271327 $block.find( '.articleFeedbackv5-expertise > input:checkbox' )
13281328 .change( function () {
1329 - var $options = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-expertise-options' );
 1329+ var $options = $.articleFeedbackv5.find( '.articleFeedbackv5-expertise-options' );
13301330 if ( $(this).is( ':checked' ) ) {
13311331 $options.slideDown( 'fast' );
13321332 } else {
@@ -1404,7 +1404,7 @@
14051405 });
14061406 rlabel.mousedown( function () {
14071407 $.articleFeedbackv5.enableSubmission( true );
1408 - var $ui = $.articleFeedbackv5.find( 'articleFeedbackv5-ui' );
 1408+ var $ui = $.articleFeedbackv5.find( '.articleFeedbackv5-ui' );
14091409 if ( $ui.hasClass( 'articleFeedbackv5-expired' ) ) {
14101410 // Changing one means the rest will get submitted too
14111411 $ui.removeClass( 'articleFeedbackv5-expired' );
@@ -1616,6 +1616,9 @@
16171617 $.articleFeedbackv5.find( '.articleFeedbackv5-expertise input:checked' ).each( function () {
16181618 data['expertise-' + $( this ).val()] = 1;
16191619 } );
 1620+ if ( $.articleFeedbackv5.find( '.articleFeedbackv5-helpimprove input:checked' ).length > 0 ) {
 1621+ data.email = $.articleFeedbackv5.find( '.articleFeedbackv5-helpimprove-email' ).val();
 1622+ }
16201623 return data;
16211624 },
16221625

Status & tagging log