r102532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102531‎ | r102532 | r102533 >
Date:17:01, 9 November 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Drop "selenium" user right. As far as I can tell, this isn't actually used anywhere (core or exts) and is leftover from the special page for selenium that was removed.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -143,7 +143,6 @@
144144 'reupload',
145145 'reupload-shared',
146146 'rollback',
147 - 'selenium',
148147 'sendemail',
149148 'siteadmin',
150149 'suppressionlog',
Index: trunk/phase3/includes/DefaultSettings.php
@@ -8,10 +8,10 @@
99 * To customize your installation, edit "LocalSettings.php". If you make
1010 * changes here, they will be lost on next upgrade of MediaWiki!
1111 *
12 - * Note that since all these string interpolations are expanded
13 - * before LocalSettings is included, if you localize something
14 - * like $wgScriptPath, you must also localize everything that
15 - * depends on it.
 12+ * In this file, variables whose default values depend on other
 13+ * variables are set to false. The actual default value of these variables
 14+ * will only be set in Setup.php, taking into account any custom settings
 15+ * performed in LocalSettings.php.
1616 *
1717 * Documentation is in the source and on:
1818 * http://www.mediawiki.org/wiki/Manual:Configuration_settings
@@ -113,7 +113,7 @@
114114 /**
115115 * The URL path to index.php.
116116 *
117 - * Defaults to "{$wgScriptPath}/index{$wgScriptExtension}".
 117+ * Will default to "{$wgScriptPath}/index{$wgScriptExtension}" in Setup.php
118118 */
119119 $wgScript = false;
120120
@@ -121,7 +121,7 @@
122122 * The URL path to redirect.php. This is a script that is used by the Nostalgia
123123 * skin.
124124 *
125 - * Defaults to "{$wgScriptPath}/redirect{$wgScriptExtension}".
 125+ * Will default to "{$wgScriptPath}/redirect{$wgScriptExtension}" in Setup.php
126126 */
127127 $wgRedirectScript = false;
128128
@@ -140,7 +140,6 @@
141141 *
142142 * These various web and file path variables are set to their defaults
143143 * in Setup.php if they are not explicitly set from LocalSettings.php.
144 - * If you do override them, be sure to set them all!
145144 *
146145 * These will relatively rarely need to be set manually, unless you are
147146 * splitting style sheets or images outside the main document root.
@@ -155,7 +154,7 @@
156155 */
157156
158157 /**
159 - * The URL path of the skins directory. Defaults to "{$wgScriptPath}/skins"
 158+ * The URL path of the skins directory. Will default to "{$wgScriptPath}/skins" in Setup.php
160159 */
161160 $wgStylePath = false;
162161 $wgStyleSheetPath = &$wgStylePath;
@@ -174,7 +173,7 @@
175174 $wgExtensionAssetsPath = false;
176175
177176 /**
178 - * Filesystem stylesheets directory. Defaults to "{$IP}/skins"
 177+ * Filesystem stylesheets directory. Will default to "{$IP}/skins" in Setup.php
179178 */
180179 $wgStyleDirectory = false;
181180
@@ -182,13 +181,13 @@
183182 * The URL path for primary article page views. This path should contain $1,
184183 * which is replaced by the article title.
185184 *
186 - * Defaults to "{$wgScript}/$1" or "{$wgScript}?title=$1", depending on
187 - * $wgUsePathInfo.
 185+ * Will default to "{$wgScript}/$1" or "{$wgScript}?title=$1" in Setup.php,
 186+ * depending on $wgUsePathInfo.
188187 */
189188 $wgArticlePath = false;
190189
191190 /**
192 - * The URL path for the images directory. Defaults to "{$wgScriptPath}/images"
 191+ * The URL path for the images directory. Will default to "{$IP}/images" in Setup.php
193192 */
194193 $wgUploadPath = false;
195194
@@ -204,7 +203,7 @@
205204
206205 /**
207206 * The URL path of the wiki logo. The logo size should be 135x135 pixels.
208 - * Defaults to "{$wgStylePath}/common/images/wiki.png".
 207+ * Will default to "{$wgStylePath}/common/images/wiki.png" in Setup.php
209208 */
210209 $wgLogo = false;
211210
@@ -223,7 +222,7 @@
224223 * The local filesystem path to a temporary directory. This is not required to
225224 * be web accessible.
226225 *
227 - * Defaults to "{$wgUploadDirectory}/tmp".
 226+ * Will default to "{$wgUploadDirectory}/tmp" in Setup.php
228227 */
229228 $wgTmpDirectory = false;
230229
@@ -1663,7 +1662,7 @@
16641663
16651664 /**
16661665 * Directory where the cached page will be saved.
1667 - * Defaults to "{$wgUploadDirectory}/cache".
 1666+ * Will default to "{$wgUploadDirectory}/cache" in Setup.php
16681667 */
16691668 $wgFileCacheDirectory = false;
16701669
@@ -4414,7 +4413,7 @@
44154414 * Its contents will be shown to users as part of the read-only warning
44164415 * message.
44174416 *
4418 - * Defaults to "{$wgUploadDirectory}/lock_yBgMBwiR".
 4417+ * Will default to "{$wgUploadDirectory}/lock_yBgMBwiR" in Setup.php
44194418 */
44204419 $wgReadOnlyFile = false;
44214420

Comments

#Comment by 😂 (talk | contribs)   17:03, 9 November 2011

Also accidentally committed a fix for bug 21590, oops ;-)

Status & tagging log