r108044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108043‎ | r108044 | r108045 >
Date:15:52, 4 January 2012
Author:mah
Status:ok
Tags:
Comment:
Fix Bug 29102 - Upgrade fails "Unknown character set: 'mysql4'

Fix suggested by Tremault and tested by maanto. Confirmed by me.
Modified paths:
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -174,7 +174,7 @@
175175 $existingEngine = false;
176176 } else {
177177 if ( preg_match( '/^latin1/', $row->Collation ) ) {
178 - $existingSchema = 'mysql4'; // TODO: This should go away/be dealt with
 178+ $existingSchema = 'latin1';
179179 } elseif ( preg_match( '/^utf8/', $row->Collation ) ) {
180180 $existingSchema = 'utf8';
181181 } elseif ( preg_match( '/^binary/', $row->Collation ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r108045* (bug 29102) Upgrade fails "Unknown character set: 'mysql4'....reedy16:14, 4 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102488fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"...mah03:25, 9 November 2011

Status & tagging log