r108045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108044‎ | r108045 | r108046 >
Date:16:14, 4 January 2012
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
* (bug 29102) Upgrade fails "Unknown character set: 'mysql4'.

"Merges" r108044
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/MysqlInstaller.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -29,6 +29,7 @@
3030 when the function exists but is disabled. Introduced Maintenance::posix_isatty().
3131 * (bug 33305) Make mw.util.addCSS resistant to IE's @font-face bug by setting
3232 cssText after DOM insertion.
 33+* (bug 29102) Upgrade fails "Unknown character set: 'mysql4'.
3334
3435 == MediaWiki 1.18 ==
3536 2011-11-24
Index: branches/REL1_18/phase3/includes/installer/MysqlInstaller.php
@@ -168,7 +168,7 @@
169169 $existingEngine = false;
170170 } else {
171171 if ( preg_match( '/^latin1/', $row->Collation ) ) {
172 - $existingSchema = 'mysql4';
 172+ $existingSchema = 'latin1';
173173 } elseif ( preg_match( '/^utf8/', $row->Collation ) ) {
174174 $existingSchema = 'utf8';
175175 } elseif ( preg_match( '/^binary/', $row->Collation ) ) {

Sign-offs

UserFlagDate
Nikerabbitinspected09:40, 5 January 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r108260Improve RELEASE-NOTES-1.18 for r108045reedy17:36, 6 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102488fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"...mah03:25, 9 November 2011
r108044Fix Bug 29102 - Upgrade fails "Unknown character set: 'mysql4'...mah15:52, 4 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   09:41, 5 January 2012

RELEASE-NOTES entry could more descriptive.

Status & tagging log