r100504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100503‎ | r100504 | r100505 >
Date:17:21, 22 October 2011
Author:hartman
Status:ok
Tags:
Comment:
Fix bug 31604.

Table should now load the tablesorter if needed, and make sure that the table is sortable.
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js
@@ -779,8 +779,11 @@
780780 .addClass( 'sortable' )
781781 .insertAfter( $( '#wikieditor-toolbar-table-preview' ) )
782782 .hide();
783 - if ( typeof jQuery.fn.tablesorter == 'function' )
784 - $( '#wikieditor-toolbar-table-preview2' ).tablesorter();
 783+
 784+ mw.loader.using( 'jquery.tablesorter', function() {
 785+ $( '#wikieditor-toolbar-table-preview2' ).tablesorter();
 786+ });
 787+
785788 $( '#wikieditor-toolbar-table-sortable' ).click( function() {
786789 // Swap the currently shown one clone with the other one
787790 $( '#wikieditor-toolbar-table-preview' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011
r102526REL1_18 MFT r100504, r100699reedy16:12, 9 November 2011

Status & tagging log