r102526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102525‎ | r102526 | r102527 >
Date:16:12, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r100504, r100699
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/WikiEditor (modified) (history)
  • /branches/REL1_18/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js
@@ -502,9 +502,11 @@
503503 }
504504 },
505505 open: function() {
 506+ // Obtain the server name without the protocol. wgServer may be protocol-relative
 507+ var serverName = mw.config.get( 'wgServer' ).replace( /^(https?:)?\/\//, '' );
506508 // Cache the articlepath regex
507509 $(this).data( 'articlePathRegex', new RegExp(
508 - '^' + $.escapeRE( mw.config.get( 'wgServer' ) + mw.config.get( 'wgArticlePath' ) )
 510+ '^https?://' + $.escapeRE( serverName + mw.config.get( 'wgArticlePath' ) )
509511 .replace( /\\\$1/g, '(.*)' ) + '$'
510512 ) );
511513 // Pre-fill the text fields based on the current selection
@@ -779,8 +781,11 @@
780782 .addClass( 'sortable' )
781783 .insertAfter( $( '#wikieditor-toolbar-table-preview' ) )
782784 .hide();
783 - if ( typeof jQuery.fn.tablesorter == 'function' )
 785+
 786+ mw.loader.using( 'jquery.tablesorter', function() {
784787 $( '#wikieditor-toolbar-table-preview2' ).tablesorter();
 788+ });
 789+
785790 $( '#wikieditor-toolbar-table-sortable' ).click( function() {
786791 // Swap the currently shown one clone with the other one
787792 $( '#wikieditor-toolbar-table-preview' )
Property changes on: branches/REL1_18/extensions/WikiEditor
___________________________________________________________________
Modified: svn:mergeinfo
788793 Merged /trunk/extensions/WikiEditor:r100504,100699
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
789794 Merged /trunk/extensions:r100504,100699

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100504Fix bug 31604....hartman17:21, 22 October 2011
r100699(bug 31499) articlePathRegex (detection of external links within the same wik...catrope14:30, 25 October 2011

Status & tagging log