r100503 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100502‎ | r100503 | r100504 >
Date:17:17, 22 October 2011
Author:robin
Status:ok
Tags:
Comment:
follow-up r100502: this works (I don't know much Javascript/jQuery :p)
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -326,8 +326,9 @@
327327 var $aftDiv = $( '<div id="mw-articlefeedback"></div>' ).articleFeedback( config );
328328
329329 // Put on bottom of article before #catlinks (if it exists)
330 -// Except in Classic, which has #catlinks above the article but inside content-div.
331 -if ( $( '#catlinks' ).length && !mw.config.get( 'skin' ) in ['standard', 'cologneblue', 'nostalgia'] ) {
 330+// Except in legacy skins, which have #catlinks above the article but inside content-div.
 331+var legacyskins = [ 'standard', 'cologneblue', 'nostalgia' ];
 332+if ( $( '#catlinks' ).length && $.inArray( mw.config.get( 'skin' ), legacyskins ) < 0 ) {
332333 $aftDiv.insertBefore( '#catlinks' );
333334 } else {
334335 // CologneBlue, Nostalgia, ...

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100502(bug 31410) ArticleFeedback widget displays at top of page in cologneblue [an...robin17:01, 22 October 2011

Status & tagging log