r99103 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99102‎ | r99103 | r99104 >
Date:13:45, 6 October 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r99102
Modified paths:
  • /branches/wmf/1.18wmf1/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/specials/SpecialContributions.php
@@ -338,7 +338,7 @@
339339 * @return String: HTML fragment
340340 */
341341 protected function getForm() {
342 - global $wgScript, $wgMiserMode;
 342+ global $wgScript;
343343
344344 $this->opts['title'] = $this->getTitle()->getPrefixedText();
345345 if( !isset( $this->opts['target'] ) ) {
@@ -388,12 +388,6 @@
389389
390390 $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagFilter'] );
391391
392 - $fNS = ( $wgMiserMode ) ? '' :
393 - Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
394 - Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
395 - Xml::namespaceSelector( $this->opts['namespace'], '' )
396 - );
397 -
398392 $f .= Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
399393 Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parsemag' ) ),
400394 'contribs', 'newbie' , 'newbie', $this->opts['contribs'] == 'newbie' ) . '<br />' .
@@ -403,7 +397,10 @@
404398 'size' => '20',
405399 'required' => ''
406400 ) + ( $this->opts['target'] ? array() : array( 'autofocus' ) ) ) . ' '.
407 - $fNS.
 401+ Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
 402+ Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
 403+ Xml::namespaceSelector( $this->opts['namespace'], '' )
 404+ ) .
408405 Xml::checkLabel( wfMsg( 'history-show-deleted' ),
409406 'deletedOnly', 'mw-show-deleted-only', $this->opts['deletedOnly'] ) . '<br />' .
410407 Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'sp-contributions-toponly' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99102Revert r88025 (put Special:Contributions namespace filter behind $wgMiserMode...catrope13:44, 6 October 2011

Status & tagging log