r102516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102515‎ | r102516 | r102517 >
Date:14:44, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r99092, r99477
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/media/JpegMetadataExtractor.php (modified) (history)
  • /branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/media/JpegMetadataExtractor.php
@@ -58,7 +58,7 @@
5959 throw new MWException( 'Too many jpeg segments. Aborting' );
6060 }
6161 if ( $buffer !== "\xFF" ) {
62 - throw new MWException( "Error reading jpeg file marker" );
 62+ throw new MWException( "Error reading jpeg file marker. Expected 0xFF but got " . bin2hex( $buffer ) );
6363 }
6464
6565 $buffer = fread( $fh, 1 );
@@ -123,6 +123,9 @@
124124 } elseif ( $buffer === "\xD9" || $buffer === "\xDA" ) {
125125 // EOI - end of image or SOS - start of scan. either way we're past any interesting segments
126126 return $segments;
 127+ } elseif ( $buffer === "\xFF" ) {
 128+ // Padding byte. Skip.
 129+ continue;
127130 } else {
128131 // segment we don't care about, so skip
129132 $size = wfUnpack( "nint", fread( $fh, 2 ), 2 );
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
130133 Merged /trunk/phase3/includes:r99477
Index: branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.js
@@ -441,7 +441,7 @@
442442
443443 function explodeRowspans( $table ) {
444444 // Split multi row cells into multiple cells with the same content
445 - $table.find( '[rowspan]' ).each(function() {
 445+ $table.find( 'tbody [rowspan]' ).each(function() {
446446 var rowSpan = this.rowSpan;
447447 this.rowSpan = 1;
448448 var cell = $( this );
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
449449 Merged /trunk/phase3:r99092,99477

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99092(bug 31420) Fix weird tablesorter bug where headers spanning multiple rows wo...catrope12:52, 6 October 2011
r99477(bug 31588, sort of) Jpeg metadata code wasn't handling padding bytes properly....bawolff14:05, 11 October 2011

Status & tagging log